| Message ID | 20200930073207.24035-1-email@uajain.com |
|---|---|
| State | Accepted |
| Commit | b83ee94fe21d09f444454cc82e5586e7b196cf05 |
| Headers | show |
| Series |
|
| Related | show |
Hi Umang, On 30/09/2020 08:32, Umang Jain wrote: > Update the sample code using utils::clamp() to std::clamp(). > > Fixes: f2734ff3ab09 ("libcamera: Replace utils::clamp() with std::clamp()") > Signed-off-by: Umang Jain <email@uajain.com> Aha - indeed, Thanks. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > Documentation/guides/pipeline-handler.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst > index 746e206..71ef205 100644 > --- a/Documentation/guides/pipeline-handler.rst > +++ b/Documentation/guides/pipeline-handler.rst > @@ -1289,7 +1289,7 @@ range definitions and their corresponding values on the device before being set. > } > > int32_t value = lroundf(it.second.get<float>() * 128 + offset); > - controls.set(cid, utils::clamp(value, 0, 255)); > + controls.set(cid, std::clamp(value, 0, 255)); > } > > for (const auto &ctrl : controls) >
Hi Umang, On Wed, Sep 30, 2020 at 01:02:07PM +0530, Umang Jain wrote: > Update the sample code using utils::clamp() to std::clamp(). > > Fixes: f2734ff3ab09 ("libcamera: Replace utils::clamp() with std::clamp()") > Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > Documentation/guides/pipeline-handler.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst > index 746e206..71ef205 100644 > --- a/Documentation/guides/pipeline-handler.rst > +++ b/Documentation/guides/pipeline-handler.rst > @@ -1289,7 +1289,7 @@ range definitions and their corresponding values on the device before being set. > } > > int32_t value = lroundf(it.second.get<float>() * 128 + offset); > - controls.set(cid, utils::clamp(value, 0, 255)); > + controls.set(cid, std::clamp(value, 0, 255)); > } > > for (const auto &ctrl : controls) > -- > 2.26.2 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 746e206..71ef205 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -1289,7 +1289,7 @@ range definitions and their corresponding values on the device before being set. } int32_t value = lroundf(it.second.get<float>() * 128 + offset); - controls.set(cid, utils::clamp(value, 0, 255)); + controls.set(cid, std::clamp(value, 0, 255)); } for (const auto &ctrl : controls)
Update the sample code using utils::clamp() to std::clamp(). Fixes: f2734ff3ab09 ("libcamera: Replace utils::clamp() with std::clamp()") Signed-off-by: Umang Jain <email@uajain.com> --- Documentation/guides/pipeline-handler.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)