[libcamera-devel,1/2] libcamera: ipa: rkisp1: Include linux/v4l2-controls.h

Message ID 20200928201311.3995725-2-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • rkisp1: Refresh user-space header
Related show

Commit Message

Niklas Söderlund Sept. 28, 2020, 8:13 p.m. UTC
Do not depend on other headers to pull in the V4L2 controls header.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/ipa/rkisp1/rkisp1.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Sept. 28, 2020, 8:16 p.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Mon, Sep 28, 2020 at 10:13:10PM +0200, Niklas Söderlund wrote:
> Do not depend on other headers to pull in the V4L2 controls header.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index d95d902adff3e244..0f5f8a8b436e60ff 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -13,6 +13,7 @@
>  #include <sys/mman.h>
>  
>  #include <linux/rkisp1-config.h>
> +#include <linux/v4l2-controls.h>
>  
>  #include <libcamera/buffer.h>
>  #include <libcamera/control_ids.h>

Patch

diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index d95d902adff3e244..0f5f8a8b436e60ff 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -13,6 +13,7 @@ 
 #include <sys/mman.h>
 
 #include <linux/rkisp1-config.h>
+#include <linux/v4l2-controls.h>
 
 #include <libcamera/buffer.h>
 #include <libcamera/control_ids.h>