[libcamera-devel,v5,3/7] libcamera: camera_sensor: Set sensor model property

9832 diff mbox series

Set the sensor model property.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
* Changes since v1
- Ensure model string only contains ASCII characters.
---
 src/libcamera/camera_sensor.cpp | 2 ++
 1 file changed, 2 insertions(+)

Hi Niklas,

On Fri, Sep 25, 2020 at 05:07:39PM +0200, Niklas Söderlund wrote:
> Set the sensor model property.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
> * Changes since v1
> - Ensure model string only contains ASCII characters.
> ---
>  src/libcamera/camera_sensor.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index d2679a4b80ce0d42..78c7ceec7c449674 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -200,6 +200,8 @@ int CameraSensor::init()
>  	else
>  		model_ = entityName;
>
> +	properties_.set(properties::Model, utils::toAscii(model_));
> +
>  	/* Create and open the subdev. */
>  	subdev_ = std::make_unique<V4L2Subdevice>(entity_);
>  	int ret = subdev_->open();
> --
> 2.28.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Hi Niklas,

Thank you for the patch.

On Fri, Sep 25, 2020 at 05:07:39PM +0200, Niklas Söderlund wrote:
> Set the sensor model property.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Provided this is still applicable when 1/7 will be approved,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> * Changes since v1
> - Ensure model string only contains ASCII characters.
> ---
>  src/libcamera/camera_sensor.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index d2679a4b80ce0d42..78c7ceec7c449674 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -200,6 +200,8 @@ int CameraSensor::init()
>  	else
>  		model_ = entityName;
>  
> +	properties_.set(properties::Model, utils::toAscii(model_));
> +
>  	/* Create and open the subdev. */
>  	subdev_ = std::make_unique<V4L2Subdevice>(entity_);
>  	int ret = subdev_->open();