[libcamera-devel,v2.1,1/11] README: Unify dependency names

Message ID 20200924144242.317020-1-ricardo@ribalda.com
State Accepted
Headers show
Series
  • [libcamera-devel,v2.1,1/11] README: Unify dependency names
Related show

Commit Message

Ricardo Ribalda Sept. 24, 2020, 2:42 p.m. UTC
All the dependencies are for libcamera, so we should move all the
packages under this paragraph, or make a paragraph for Meson, and a
second one for python3-yaml. I think the later is more clear.

Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
---
 README.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Laurent Pinchart Sept. 24, 2020, 3:05 p.m. UTC | #1
Hi Ricardo,

Thank you for the patch.

On Thu, Sep 24, 2020 at 04:42:41PM +0200, Ricardo Ribalda wrote:
> All the dependencies are for libcamera, so we should move all the
> packages under this paragraph, or make a paragraph for Meson, and a
> second one for python3-yaml. I think the later is more clear.
> 
> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  README.rst | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 40d4519..93141ee 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -46,8 +46,8 @@ Other distributions may have differing package names:
>  A C++ toolchain: [required]
>  	Either {g++, clang}
>  
> -for libcamera: [required]
> -        meson (>= 0.47) ninja-build python3-yaml
> +Meson Build system: [required]
> +        meson (>= 0.47) ninja-build
>  
>          If your distribution doesn't provide a recent enough version of meson,
>          you can install or upgrade it using pip3.
> @@ -57,6 +57,9 @@ for libcamera: [required]
>              pip3 install --user meson
>              pip3 install --user --upgrade meson
>  
> +for the libcamera core: [required]
> +        python3-yaml
> +
>  for device hotplug enumeration: [optional]
>  	pkg-config libudev-dev

Patch

diff --git a/README.rst b/README.rst
index 40d4519..93141ee 100644
--- a/README.rst
+++ b/README.rst
@@ -46,8 +46,8 @@  Other distributions may have differing package names:
 A C++ toolchain: [required]
 	Either {g++, clang}
 
-for libcamera: [required]
-        meson (>= 0.47) ninja-build python3-yaml
+Meson Build system: [required]
+        meson (>= 0.47) ninja-build
 
         If your distribution doesn't provide a recent enough version of meson,
         you can install or upgrade it using pip3.
@@ -57,6 +57,9 @@  for libcamera: [required]
             pip3 install --user meson
             pip3 install --user --upgrade meson
 
+for the libcamera core: [required]
+        python3-yaml
+
 for device hotplug enumeration: [optional]
 	pkg-config libudev-dev