| Message ID | 20200924071922.231063-12-ricardo@ribalda.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Ricardo, Thank you for the patch. On Thu, Sep 24, 2020 at 09:19:22AM +0200, Ricardo Ribalda wrote: > Yaml is not installed by default, so it needs to be checked during > configuration for its presence. > > Credit-to: Ezequiel Garcia <ezequiel@collabora.com> > Cc: Ezequiel Garcia <ezequiel@collabora.com> > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> If you don't mind, I'll apply https://lists.libcamera.org/pipermail/libcamera-devel/2019-November/005517.html instead. > --- > src/libcamera/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > index 0e6ecf5..575bea1 100644 > --- a/src/libcamera/meson.build > +++ b/src/libcamera/meson.build > @@ -77,6 +77,7 @@ if libudev.found() > ]) > endif > > +import('python').find_installation('python3', modules : ['yaml']) > gen_controls = files('gen-controls.py') > > control_sources = []
HI On Thu, Sep 24, 2020 at 4:09 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Thu, Sep 24, 2020 at 09:19:22AM +0200, Ricardo Ribalda wrote: > > Yaml is not installed by default, so it needs to be checked during > > configuration for its presence. > > > > Credit-to: Ezequiel Garcia <ezequiel@collabora.com> > > Cc: Ezequiel Garcia <ezequiel@collabora.com> > > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> > > If you don't mind, I'll apply > https://lists.libcamera.org/pipermail/libcamera-devel/2019-November/005517.html > instead. Sure!, no worries > > > --- > > src/libcamera/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > > index 0e6ecf5..575bea1 100644 > > --- a/src/libcamera/meson.build > > +++ b/src/libcamera/meson.build > > @@ -77,6 +77,7 @@ if libudev.found() > > ]) > > endif > > > > +import('python').find_installation('python3', modules : ['yaml']) > > gen_controls = files('gen-controls.py') > > > > control_sources = [] > > -- > Regards, > > Laurent Pinchart
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index 0e6ecf5..575bea1 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -77,6 +77,7 @@ if libudev.found() ]) endif +import('python').find_installation('python3', modules : ['yaml']) gen_controls = files('gen-controls.py') control_sources = []
Yaml is not installed by default, so it needs to be checked during configuration for its presence. Credit-to: Ezequiel Garcia <ezequiel@collabora.com> Cc: Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> --- src/libcamera/meson.build | 1 + 1 file changed, 1 insertion(+)