[libcamera-devel,6/9] README: Add missing libtiff-dev package for qcam

Message ID 20200923151522.56778-7-ricardo@ribalda.com
State Accepted
Headers show
Series
  • Fix README.rst
Related show

Commit Message

Ricardo Ribalda Sept. 23, 2020, 3:15 p.m. UTC
Without it:

Run-time dependency libtiff-4 found: NO (tried pkgconfig and cmake)

Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Sept. 23, 2020, 8:12 p.m. UTC | #1
Hi Ricardo,

On 23/09/2020 16:15, Ricardo Ribalda wrote:
> Without it:
> 
> Run-time dependency libtiff-4 found: NO (tried pkgconfig and cmake)
> 
> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index d651fe2..720f706 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -73,7 +73,7 @@ for gstreamer: [optional]
>  	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
>  for qcam: [optional]
> -	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools
> +	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev

Hrm ... so all the other packages are optional and required to enable
qcam, but isn't libtiff-dev optional within qcam itself? I.e. we can
still build qcam without it (just disables the dng-writer)?

But I'm not sure how to express an optional, optional component - so
maybe this is fine - unless there's an obvious way to express that...

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
>

Patch

diff --git a/README.rst b/README.rst
index d651fe2..720f706 100644
--- a/README.rst
+++ b/README.rst
@@ -73,7 +73,7 @@  for gstreamer: [optional]
 	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
 
 for qcam: [optional]
-	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools
+	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
 
 Using GStreamer plugin
 ~~~~~~~~~~~~~~~~~~~~~~