[libcamera-devel,5/9] README: Add missing package for Qt5 tools

Message ID 20200923151522.56778-6-ricardo@ribalda.com
State Accepted
Headers show
Series
  • Fix README.rst
Related show

Commit Message

Ricardo Ribalda Sept. 23, 2020, 3:15 p.m. UTC
Without it:

Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO
Program lrelease-qt5 found: NO
Program lrelease found: NO found  but need: '== 5.14.2'

Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Sept. 23, 2020, 8:05 p.m. UTC | #1
Hi Ricardo,

On 23/09/2020 16:15, Ricardo Ribalda wrote:
> Without it:
> 
> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO
> Program lrelease-qt5 found: NO
> Program lrelease found: NO found  but need: '== 5.14.2'
> 
> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 836750a..d651fe2 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -73,7 +73,7 @@ for gstreamer: [optional]
>  	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
>  for qcam: [optional]
> -	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
> +	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools

Oh, I'm sure I've only ever had to copy/paste that line of packages to
get a successful build.

I wonder what the differences are - perhaps my system pulled in the
qttools5-dev-tools through some other dependency chain, but I can see it
is installed on my system.

No harm being explicit if there is a situation that requires it I think.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
>

Patch

diff --git a/README.rst b/README.rst
index 836750a..d651fe2 100644
--- a/README.rst
+++ b/README.rst
@@ -73,7 +73,7 @@  for gstreamer: [optional]
 	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
 
 for qcam: [optional]
-	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
+	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools
 
 Using GStreamer plugin
 ~~~~~~~~~~~~~~~~~~~~~~