| Message ID | 20200923151522.56778-4-ricardo@ribalda.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Ricardo, On 23/09/2020 16:15, Ricardo Ribalda wrote: > Without it: > > Run-time dependency libudev found: NO (tried pkgconfig and cmake) > Run-time dependency threads found: YES > Run-time dependency Boost found: NO > > src/ipa/raspberrypi/meson.build:5:0: ERROR: Dependency "boost" not found This one is actually optional - it's just a sub-optimal method to work around it. I'd really like this to be automatic so that if it's not found the raspberry-pi pipeline is disabled, and I even have a patch I created several weeks ago. But I'm not particularly happy with that - and so I haven't submitted it ;-( > > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> > --- > README.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/README.rst b/README.rst > index cfd0be7..9013c1d 100644 > --- a/README.rst > +++ b/README.rst > @@ -57,6 +57,9 @@ Meson Build system: [required] > pip3 install --user meson > pip3 install --user --upgrade meson > > +Boost C++ Libraries: [required] I think we could add this as [optional], stating that it is required to enable the RPi IPA. The difficulty is that the RPi IPA is enabled by default, so that's why it impacts users more. To disable, you can specify -Dpipelines=vimc,uvcvideo,ipu3,rkisp1 on the meson configuration line. That's not particularly friendly either though - so maybe I should just post my patch to disable the RPi IPA when there is no boost library found, and hash it out on there. -- Kieran > + libboost-dev > + > for IPA module signing: [required] > libgnutls28-dev openssl > >
On Wed, Sep 23, 2020 at 08:57:58PM +0100, Kieran Bingham wrote: > Hi Ricardo, > > On 23/09/2020 16:15, Ricardo Ribalda wrote: > > Without it: > > > > Run-time dependency libudev found: NO (tried pkgconfig and cmake) > > Run-time dependency threads found: YES > > Run-time dependency Boost found: NO > > > > src/ipa/raspberrypi/meson.build:5:0: ERROR: Dependency "boost" not found > > This one is actually optional - it's just a sub-optimal method to work > around it. > > I'd really like this to be automatic so that if it's not found the > raspberry-pi pipeline is disabled, and I even have a patch I created > several weeks ago. > > But I'm not particularly happy with that - and so I haven't submitted it ;-( > > > > > > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> > > --- > > README.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/README.rst b/README.rst > > index cfd0be7..9013c1d 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -57,6 +57,9 @@ Meson Build system: [required] > > pip3 install --user meson > > pip3 install --user --upgrade meson > > > > +Boost C++ Libraries: [required] > > I think we could add this as [optional], stating that it is required to > enable the RPi IPA. > > The difficulty is that the RPi IPA is enabled by default, so that's why > it impacts users more. > > To disable, you can specify -Dpipelines=vimc,uvcvideo,ipu3,rkisp1 on the > meson configuration line. > > That's not particularly friendly either though - so maybe I should just > post my patch to disable the RPi IPA when there is no boost library > found, and hash it out on there. Good idea. I can already provide one review comment, even before I see the code :-) I'd like this to be implemented in a generic way that will allow each IPA to state its dependencies in its meson.build file. I think we'll then need to populate a variable to store the list of actually enabled pipeline handlers, and replace the get_options('pipelines') with that in the top-level meson.build file. It would be neat if the IPA dependency could be handled in the IPA meson.build file, but src/libcamera/ is included before src/ipa/, and we need to select pipeline handlers in src/libcamera/pipelines/. I'm not sure if we could solve this one easily. > > + libboost-dev > > + > > for IPA module signing: [required] > > libgnutls28-dev openssl > >
diff --git a/README.rst b/README.rst index cfd0be7..9013c1d 100644 --- a/README.rst +++ b/README.rst @@ -57,6 +57,9 @@ Meson Build system: [required] pip3 install --user meson pip3 install --user --upgrade meson +Boost C++ Libraries: [required] + libboost-dev + for IPA module signing: [required] libgnutls28-dev openssl
Without it: Run-time dependency libudev found: NO (tried pkgconfig and cmake) Run-time dependency threads found: YES Run-time dependency Boost found: NO src/ipa/raspberrypi/meson.build:5:0: ERROR: Dependency "boost" not found Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> --- README.rst | 3 +++ 1 file changed, 3 insertions(+)