| Message ID | 20200923151522.56778-2-ricardo@ribalda.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Ricardo, On 23/09/2020 16:15, Ricardo Ribalda wrote: > All the dependencies are for libcamera, so we should move all the > packages under this section, or make a section for Meson. I think the > second is more clear. > > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> > --- > README.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.rst b/README.rst > index 40d4519..2863326 100644 > --- a/README.rst > +++ b/README.rst > @@ -46,7 +46,7 @@ Other distributions may have differing package names: > A C++ toolchain: [required] > Either {g++, clang} > > -for libcamera: [required] > +Meson Build system: [required] > meson (>= 0.47) ninja-build python3-yaml python3-yaml isn't required for meson, it's required for the libcamera-core ... So I'm not certain on this. I think the intent was to describe the minimum packages required... > > If your distribution doesn't provide a recent enough version of meson, >
On Wed, Sep 23, 2020 at 09:00:00PM +0100, Kieran Bingham wrote: > Hi Ricardo, > > On 23/09/2020 16:15, Ricardo Ribalda wrote: > > All the dependencies are for libcamera, so we should move all the > > packages under this section, or make a section for Meson. I think the > > second is more clear. > > > > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> > > --- > > README.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.rst b/README.rst > > index 40d4519..2863326 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -46,7 +46,7 @@ Other distributions may have differing package names: > > A C++ toolchain: [required] > > Either {g++, clang} > > > > -for libcamera: [required] > > +Meson Build system: [required] > > meson (>= 0.47) ninja-build python3-yaml > > python3-yaml isn't required for meson, it's required for the > libcamera-core ... So I'm not certain on this. > > I think the intent was to describe the minimum packages required... Correct. Maybe this should read "for libcamera core" ? > > > > If your distribution doesn't provide a recent enough version of meson, > >
diff --git a/README.rst b/README.rst index 40d4519..2863326 100644 --- a/README.rst +++ b/README.rst @@ -46,7 +46,7 @@ Other distributions may have differing package names: A C++ toolchain: [required] Either {g++, clang} -for libcamera: [required] +Meson Build system: [required] meson (>= 0.47) ninja-build python3-yaml If your distribution doesn't provide a recent enough version of meson,
All the dependencies are for libcamera, so we should move all the packages under this section, or make a section for Meson. I think the second is more clear. Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)