[libcamera-devel] libcamera: pipeline_handler: Add missing forward declaration of StreamUsage

968 diff mbox series

When switching to stream usages in the PipelineHandler StreamUsage was
was not forward declared as it should and was hid by other include
files, fix this.

Fixes: 20a6455e0b62575b ("libcamera: camera: Add support for stream usages")
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/include/pipeline_handler.h | 1 +
 1 file changed, 1 insertion(+)

Hi Niklas,

On 14/04/2019 01:34, Niklas Söderlund wrote:
> When switching to stream usages in the PipelineHandler StreamUsage was
> was not forward declared as it should and was hid by other include
> files, fix this.

So it is.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Fixes: 20a6455e0b62575b ("libcamera: camera: Add support for stream usages")
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  src/libcamera/include/pipeline_handler.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index b6cbd3bae51b08dc..33b820e706cccb2e 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -26,6 +26,7 @@ class PipelineHandler;
>  class Request;
>  class Stream;
>  class StreamConfiguration;
> +class StreamUsage;
>  
>  class CameraData
>  {
>

Hi Kieran,

On 2019-04-14 11:49:39 +0100, Kieran Bingham wrote:
> Hi Niklas,
> 
> On 14/04/2019 01:34, Niklas Söderlund wrote:
> > When switching to stream usages in the PipelineHandler StreamUsage was
> > was not forward declared as it should and was hid by other include
> > files, fix this.
> 
> So it is.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Thanks, pushed to master.

> 
> > Fixes: 20a6455e0b62575b ("libcamera: camera: Add support for stream usages")
> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> > ---
> >  src/libcamera/include/pipeline_handler.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> > index b6cbd3bae51b08dc..33b820e706cccb2e 100644
> > --- a/src/libcamera/include/pipeline_handler.h
> > +++ b/src/libcamera/include/pipeline_handler.h
> > @@ -26,6 +26,7 @@ class PipelineHandler;
> >  class Request;
> >  class Stream;
> >  class StreamConfiguration;
> > +class StreamUsage;
> >  
> >  class CameraData
> >  {
> > 
> 
> -- 
> Regards
> --
> Kieran