| Message ID | 20200911162039.61933-2-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hello On Fri, Sep 11, 2020 at 06:20:34PM +0200, Jacopo Mondi wrote: > Define a control to report the AWB algorithm locking state. > The control definition is copied from the AeLocked one. Gentle ping on this single patch which I think could be fast-tracked > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/control_ids.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml > index 3560d4a81882..4c415545dcae 100644 > --- a/src/libcamera/control_ids.yaml > +++ b/src/libcamera/control_ids.yaml > @@ -208,6 +208,17 @@ controls: > value: 7 > description: Maximum allowed value (place any new values above here). > > + - AwbLocked: > + type: bool > + description: | > + Report the lock status of a running AWB algorithm. > + > + If the AWB algorithm is locked the value shall be set to true, if it's > + converging it shall be set to false. If the AWB algorithm is not > + running the control shall not be present in the metadata control list. > + > + \sa AwbEnable > + > - ColourGains: > type: float > description: | > -- > 2.28.0 >
Hi Jacopo, On 11/09/2020 17:20, Jacopo Mondi wrote: > Define a control to report the AWB algorithm locking state. > The control definition is copied from the AeLocked one. > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/control_ids.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml > index 3560d4a81882..4c415545dcae 100644 > --- a/src/libcamera/control_ids.yaml > +++ b/src/libcamera/control_ids.yaml > @@ -208,6 +208,17 @@ controls: > value: 7 > description: Maximum allowed value (place any new values above here). > > + - AwbLocked: > + type: bool > + description: | > + Report the lock status of a running AWB algorithm. > + > + If the AWB algorithm is locked the value shall be set to true, if it's > + converging it shall be set to false. If the AWB algorithm is not > + running the control shall not be present in the metadata control list. > + > + \sa AwbEnable That seems nice and clear! Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > + > - ColourGains: > type: float > description: | >
diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 3560d4a81882..4c415545dcae 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -208,6 +208,17 @@ controls: value: 7 description: Maximum allowed value (place any new values above here). + - AwbLocked: + type: bool + description: | + Report the lock status of a running AWB algorithm. + + If the AWB algorithm is locked the value shall be set to true, if it's + converging it shall be set to false. If the AWB algorithm is not + running the control shall not be present in the metadata control list. + + \sa AwbEnable + - ColourGains: type: float description: |