| Message ID | 20200907123717.24421-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Mon, Sep 07, 2020 at 02:37:17PM +0200, Jacopo Mondi wrote: > Just a small spelling fix: s/re-allcoation/re-allocation > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/android/camera_device.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > index 7edb3932f2c1..89b00a8c8ec7 100644 > --- a/src/android/camera_device.cpp > +++ b/src/android/camera_device.cpp > @@ -1185,7 +1185,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) > /* > * Clear and remove any existing configuration from previous calls, and > * ensure the required entries are available without further > - * re-allcoation. > + * re-allocation. While at it, I'd switch to the correct spelling 'reallocation' :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > */ > streams_.clear(); > streams_.reserve(stream_list->num_streams);
On 07/09/2020 13:37, Jacopo Mondi wrote: > Just a small spelling fix: s/re-allcoation/re-allocation > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/android/camera_device.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > index 7edb3932f2c1..89b00a8c8ec7 100644 > --- a/src/android/camera_device.cpp > +++ b/src/android/camera_device.cpp > @@ -1185,7 +1185,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) > /* > * Clear and remove any existing configuration from previous calls, and > * ensure the required entries are available without further > - * re-allcoation. > + * re-allocation. Also probably with 'reallocation' as suggested by Laurent: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > */ > streams_.clear(); > streams_.reserve(stream_list->num_streams); > -- > 2.28.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel >
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 7edb3932f2c1..89b00a8c8ec7 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1185,7 +1185,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) /* * Clear and remove any existing configuration from previous calls, and * ensure the required entries are available without further - * re-allcoation. + * re-allocation. */ streams_.clear(); streams_.reserve(stream_list->num_streams);
Just a small spelling fix: s/re-allcoation/re-allocation Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/android/camera_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0