[libcamera-devel] libcamera: pipeline: ipu3: Remove stray "imgu." file

Message ID 20200822141557.29511-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit d6eab60597529c0260bb6d783134a99ba31f564f
Headers show
Series
  • [libcamera-devel] libcamera: pipeline: ipu3: Remove stray "imgu." file
Related show

Commit Message

Laurent Pinchart Aug. 22, 2020, 2:15 p.m. UTC
Commit 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed
parameters") added an empty "imgu." file by mistake. Remove it.

Fixes: 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed parameters")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/imgu. | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 src/libcamera/pipeline/ipu3/imgu.

Comments

Kieran Bingham Aug. 24, 2020, 9:38 a.m. UTC | #1
Hi Laurent,

On 22/08/2020 15:15, Laurent Pinchart wrote:
> Commit 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed
> parameters") added an empty "imgu." file by mistake. Remove it.
> 
> Fixes: 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed parameters")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/imgu. | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  delete mode 100644 src/libcamera/pipeline/ipu3/imgu.
> 
> diff --git a/src/libcamera/pipeline/ipu3/imgu. b/src/libcamera/pipeline/ipu3/imgu.
> deleted file mode 100644
> index e69de29bb2d1..000000000000
>
Niklas Söderlund Aug. 24, 2020, 10:05 p.m. UTC | #2
Hi Laurent,

Thanks for your work.

On 2020-08-22 17:15:57 +0300, Laurent Pinchart wrote:
> Commit 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed
> parameters") added an empty "imgu." file by mistake. Remove it.
> 
> Fixes: 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed parameters")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Wops :-)

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/pipeline/ipu3/imgu. | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  delete mode 100644 src/libcamera/pipeline/ipu3/imgu.
> 
> diff --git a/src/libcamera/pipeline/ipu3/imgu. b/src/libcamera/pipeline/ipu3/imgu.
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Jacopo Mondi Aug. 25, 2020, 7:45 a.m. UTC | #3
Hi Laurent

On Sat, Aug 22, 2020 at 05:15:57PM +0300, Laurent Pinchart wrote:
> Commit 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed
> parameters") added an empty "imgu." file by mistake. Remove it.
>
> Fixes: 15df621fb9a7 ("libcamera: ipu3: Configure ImgU with the computed parameters")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Ouch, my bad :/
Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/libcamera/pipeline/ipu3/imgu. | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  delete mode 100644 src/libcamera/pipeline/ipu3/imgu.
>
> diff --git a/src/libcamera/pipeline/ipu3/imgu. b/src/libcamera/pipeline/ipu3/imgu.
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/pipeline/ipu3/imgu. b/src/libcamera/pipeline/ipu3/imgu.
deleted file mode 100644
index e69de29bb2d1..000000000000