[libcamera-devel,v3,1/7] libcamera: properties: Add model property

Message ID 20200813095726.3497193-2-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: Allow for user-friendly names in applications
Related show

Commit Message

Niklas Söderlund Aug. 13, 2020, 9:57 a.m. UTC
The model property describes the camera model name.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/property_ids.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kieran Bingham Aug. 13, 2020, 3:19 p.m. UTC | #1
Hi Niklas,

On 13/08/2020 10:57, Niklas Söderlund wrote:
> The model property describes the camera model name.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Aha, OK now I see where we're going to get our friendly names back.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  src/libcamera/property_ids.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 74ad0195d6310367..1e844dfa7d821e7d 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -387,6 +387,13 @@ controls:
>                                |                    |
>                                +--------------------+
>  
> +  - Model:
> +      type: string
> +      description: |
> +        Model name of the camera sensor. The format of the string is free-form
> +        and should be encoded as ASCII. Example model names are 'ov5670',

'as' ASCII or 'in' ASCII ?

(I don't know which is more correct, but 'in' is probably what I would
have written, it might not be a better choice though)


> +        'imx219' or 'Logitech Webcam C930e'.
> +
>    - UnitCellSize:
>        type: Size
>        description: |
>

Patch

diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
index 74ad0195d6310367..1e844dfa7d821e7d 100644
--- a/src/libcamera/property_ids.yaml
+++ b/src/libcamera/property_ids.yaml
@@ -387,6 +387,13 @@  controls:
                               |                    |
                               +--------------------+
 
+  - Model:
+      type: string
+      description: |
+        Model name of the camera sensor. The format of the string is free-form
+        and should be encoded as ASCII. Example model names are 'ov5670',
+        'imx219' or 'Logitech Webcam C930e'.
+
   - UnitCellSize:
       type: Size
       description: |