[libcamera-devel,1/2] libcamera: controls: Define AwbLocked control

Message ID 20200808100046.5347-2-jacopo@jmondi.org
State Accepted
Headers show
Series
  • libcamera: controls: Define draft controls
Related show

Commit Message

Jacopo Mondi Aug. 8, 2020, 10 a.m. UTC
Define a control to report the AWB algorithm locking state.
The control definition is copied from the AeLocked one.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/control_ids.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Niklas Söderlund Aug. 8, 2020, 10:32 a.m. UTC | #1
Hi Jacopo,

Thanks for your work.

On 2020-08-08 12:00:45 +0200, Jacopo Mondi wrote:
> Define a control to report the AWB algorithm locking state.
> The control definition is copied from the AeLocked one.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/control_ids.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 3560d4a81882..4c415545dcae 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -208,6 +208,17 @@ controls:
>            value: 7
>            description: Maximum allowed value (place any new values above here).
>  
> +  - AwbLocked:
> +      type: bool
> +      description: |
> +        Report the lock status of a running AWB algorithm.
> +
> +        If the AWB algorithm is locked the value shall be set to true, if it's
> +        converging it shall be set to false. If the AWB algorithm is not
> +        running the control shall not be present in the metadata control list.
> +
> +        \sa AwbEnable
> +
>    - ColourGains:
>        type: float
>        description: |
> -- 
> 2.27.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 3560d4a81882..4c415545dcae 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -208,6 +208,17 @@  controls:
           value: 7
           description: Maximum allowed value (place any new values above here).
 
+  - AwbLocked:
+      type: bool
+      description: |
+        Report the lock status of a running AWB algorithm.
+
+        If the AWB algorithm is locked the value shall be set to true, if it's
+        converging it shall be set to false. If the AWB algorithm is not
+        running the control shall not be present in the metadata control list.
+
+        \sa AwbEnable
+
   - ColourGains:
       type: float
       description: |