[libcamera-devel] libcamera: Add missing header files to meson.build

923 diff mbox series

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/meson.build | 2 ++
 1 file changed, 2 insertions(+)

Hi Niklas,

Thank you for the patch.

On Fri, Apr 05, 2019 at 10:01:10PM +0200, Niklas Söderlund wrote:
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

You may have wanted to explain why you don't include geometry.h here, or
even include it, but otherwise,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index b2fe0e4f4080c6fd..cd36ac3075180ef6 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -25,12 +25,14 @@ libcamera_sources = files([
>  libcamera_headers = files([
>      'include/device_enumerator.h',
>      'include/event_dispatcher_poll.h',
> +    'include/formats.h',
>      'include/log.h',
>      'include/media_device.h',
>      'include/media_object.h',
>      'include/pipeline_handler.h',
>      'include/utils.h',
>      'include/v4l2_device.h',
> +    'include/v4l2_subdevice.h',
>  ])
>  
>  libcamera_internal_includes =  include_directories('include')

Hi,

On 2019-04-06 19:20:13 +0300, Laurent Pinchart wrote:
> Hi Niklas,
> 
> Thank you for the patch.
> 
> On Fri, Apr 05, 2019 at 10:01:10PM +0200, Niklas Söderlund wrote:
> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> 
> You may have wanted to explain why you don't include geometry.h here, or
> even include it, but otherwise,

Or I can wait so that geometry.h is already moved before pushing :-)

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks this is now pushed to master.

> 
> > ---
> >  src/libcamera/meson.build | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> > index b2fe0e4f4080c6fd..cd36ac3075180ef6 100644
> > --- a/src/libcamera/meson.build
> > +++ b/src/libcamera/meson.build
> > @@ -25,12 +25,14 @@ libcamera_sources = files([
> >  libcamera_headers = files([
> >      'include/device_enumerator.h',
> >      'include/event_dispatcher_poll.h',
> > +    'include/formats.h',
> >      'include/log.h',
> >      'include/media_device.h',
> >      'include/media_object.h',
> >      'include/pipeline_handler.h',
> >      'include/utils.h',
> >      'include/v4l2_device.h',
> > +    'include/v4l2_subdevice.h',
> >  ])
> >  
> >  libcamera_internal_includes =  include_directories('include')
> 
> -- 
> Regards,
> 
> Laurent Pinchart