[libcamera-devel,v2,1/2] include: drm_fourcc: Add 16-bit Bayer FourCC

Message ID 20200724171404.736509-2-niklas.soderlund@ragnatech.se
State Accepted
Commit 90c793c6989fe6913faec920649062ad64b43ff0
Headers show
Series
  • libcamera: Add support for 16-bit Bayer formats
Related show

Commit Message

Niklas Söderlund July 24, 2020, 5:14 p.m. UTC
The patch trying to upstream Bayer formats to the DRM FourCC header file
in Linux left out the 16-bit formats, add them. This addition will be
included in the next version of the DRM Bayer patch sent out.

Intention is to merge this in libcamera and update the header file once
the upstream patch is picked up.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
* Changes since v1
- Use non conflicting FourCC for DRM_FORMAT_SRGGB16.
---
 include/linux/drm_fourcc.h | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Laurent Pinchart July 24, 2020, 5:26 p.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Fri, Jul 24, 2020 at 07:14:03PM +0200, Niklas Söderlund wrote:
> The patch trying to upstream Bayer formats to the DRM FourCC header file
> in Linux left out the 16-bit formats, add them. This addition will be
> included in the next version of the DRM Bayer patch sent out.
> 
> Intention is to merge this in libcamera and update the header file once
> the upstream patch is picked up.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> * Changes since v1
> - Use non conflicting FourCC for DRM_FORMAT_SRGGB16.
> ---
>  include/linux/drm_fourcc.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h
> index 69240dfe1df0df28..72453692bdefacc4 100644
> --- a/include/linux/drm_fourcc.h
> +++ b/include/linux/drm_fourcc.h
> @@ -344,6 +344,12 @@ extern "C" {
>  #define DRM_FORMAT_SGBRG14	fourcc_code('G', 'B', '1', '4')
>  #define DRM_FORMAT_SBGGR14	fourcc_code('B', 'G', '1', '4')
>  
> +/* 16-bit Bayer formats */
> +#define DRM_FORMAT_SRGGB16	fourcc_code('R', 'G', 'B', '6')
> +#define DRM_FORMAT_SGRBG16	fourcc_code('G', 'R', '1', '6')
> +#define DRM_FORMAT_SGBRG16	fourcc_code('G', 'B', '1', '6')
> +#define DRM_FORMAT_SBGGR16	fourcc_code('B', 'Y', 'R', '2')
> +
>  /*
>   * Format Modifiers:
>   *

Patch

diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h
index 69240dfe1df0df28..72453692bdefacc4 100644
--- a/include/linux/drm_fourcc.h
+++ b/include/linux/drm_fourcc.h
@@ -344,6 +344,12 @@  extern "C" {
 #define DRM_FORMAT_SGBRG14	fourcc_code('G', 'B', '1', '4')
 #define DRM_FORMAT_SBGGR14	fourcc_code('B', 'G', '1', '4')
 
+/* 16-bit Bayer formats */
+#define DRM_FORMAT_SRGGB16	fourcc_code('R', 'G', 'B', '6')
+#define DRM_FORMAT_SGRBG16	fourcc_code('G', 'R', '1', '6')
+#define DRM_FORMAT_SGBRG16	fourcc_code('G', 'B', '1', '6')
+#define DRM_FORMAT_SBGGR16	fourcc_code('B', 'Y', 'R', '2')
+
 /*
  * Format Modifiers:
  *