[libcamera-devel,v2,3/4] test: file: Add file creation test
diff mbox series

Message ID 20200714090936.9562-3-laurent.pinchart@ideasonboard.com
State Accepted
Commit aca22bc73a10003d26f6c4f4ecdec7ba54910a00
Headers show
Series
  • [libcamera-devel,v2,1/4] libcamera: file: Add read/write support
Related show

Commit Message

Laurent Pinchart July 14, 2020, 9:09 a.m. UTC 
Add a test to verify file creation with File::open(). The test is
expected to fail as the File::open() implementation is not correct.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 test/file.cpp | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/test/file.cpp b/test/file.cpp
index 7688a9dc224a..f458f355ccad 100644
--- a/test/file.cpp
+++ b/test/file.cpp
@@ -31,6 +31,7 @@  protected:
 			return TestFail;
 
 		close(fd);
+		unlink(fileName_.c_str());
 
 		return TestPass;
 	}
@@ -191,14 +192,37 @@  protected:
 
 		file.close();
 
+		/* Test file creation. */
+		file.setFileName(fileName_);
+
+		if (file.exists()) {
+			cerr << "Temporary file already exists" << endl;
+			return TestFail;
+		}
+
+		if (file.open(File::ReadOnly)) {
+			cerr << "Read-only open succeeded on nonexistent file" << endl;
+			return TestFail;
+		}
+
+		if (!file.open(File::WriteOnly)) {
+			cerr << "Write-only open failed on nonexistent file" << endl;
+			return TestFail;
+		}
+
+		if (!file.exists()) {
+			cerr << "Write-only open failed to create file" << endl;
+			return TestFail;
+		}
+
+		file.close();
+
 		/* Test read and write. */
 		std::array<uint8_t, 256> buffer = { 0 };
 
 		strncpy(reinterpret_cast<char *>(buffer.data()), "libcamera",
 			buffer.size());
 
-		file.setFileName(fileName_);
-
 		if (file.read(buffer) >= 0) {
 			cerr << "Read succeeded on closed file" << endl;
 			return TestFail;