| Message ID | 20200704005227.21782-5-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Sat, Jul 04, 2020 at 03:52:19AM +0300, Laurent Pinchart wrote: > The controls variable in PipelineHandlerRPi::start() is unused. Drop it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index ab4b915156e1..db0b20135318 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream, > int PipelineHandlerRPi::start(Camera *camera) > { > RPiCameraData *data = cameraData(camera); > - ControlList controls(data->sensor_->controls()); > int ret; > > /* Allocate buffers for internal pipeline usage. */ > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Laurent, On Sat, 4 Jul 2020 at 01:52, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > The controls variable in PipelineHandlerRPi::start() is unused. Drop it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index ab4b915156e1..db0b20135318 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream, > int PipelineHandlerRPi::start(Camera *camera) > { > RPiCameraData *data = cameraData(camera); > - ControlList controls(data->sensor_->controls()); > int ret; > > /* Allocate buffers for internal pipeline usage. */ > -- > Regards, > > Laurent Pinchart >
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index ab4b915156e1..db0b20135318 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream, int PipelineHandlerRPi::start(Camera *camera) { RPiCameraData *data = cameraData(camera); - ControlList controls(data->sensor_->controls()); int ret; /* Allocate buffers for internal pipeline usage. */
The controls variable in PipelineHandlerRPi::start() is unused. Drop it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 - 1 file changed, 1 deletion(-)