Message ID | 20200628231934.29025-3-laurent.pinchart@ideasonboard.com |
---|---|
State | Superseded |
Headers | show |
Series |
|
Related | show |
Hi Laurent, Thanks for your patch. On 2020-06-29 02:19:27 +0300, Laurent Pinchart wrote: > A comment copied from the IPAInterfaceWrapper incorrectly mentions the > IPAInterfaceWrapper class instead of the IPAContextWrapper class. Fix > it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/ipa_context_wrapper.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp > index 054aa6ba2089..471118f57cdc 100644 > --- a/src/libcamera/ipa_context_wrapper.cpp > +++ b/src/libcamera/ipa_context_wrapper.cpp > @@ -283,7 +283,7 @@ void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame, > #ifndef __DOXYGEN__ > /* > * This construct confuses Doxygen and makes it believe that all members of the > - * operations is a member of IPAInterfaceWrapper. It must thus be hidden. > + * operations is a member of IPAContextWrapper. It must thus be hidden. > */ > const struct ipa_callback_ops IPAContextWrapper::callbacks_ = { > .queue_frame_action = &IPAContextWrapper::queue_frame_action, > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi LAurent On Mon, Jun 29, 2020 at 04:25:21PM +0200, Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your patch. > > On 2020-06-29 02:19:27 +0300, Laurent Pinchart wrote: > > A comment copied from the IPAInterfaceWrapper incorrectly mentions the > > IPAInterfaceWrapper class instead of the IPAContextWrapper class. Fix > > it. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > > --- > > src/libcamera/ipa_context_wrapper.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp > > index 054aa6ba2089..471118f57cdc 100644 > > --- a/src/libcamera/ipa_context_wrapper.cpp > > +++ b/src/libcamera/ipa_context_wrapper.cpp > > @@ -283,7 +283,7 @@ void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame, > > #ifndef __DOXYGEN__ > > /* > > * This construct confuses Doxygen and makes it believe that all members of the > > - * operations is a member of IPAInterfaceWrapper. It must thus be hidden. > > + * operations is a member of IPAContextWrapper. It must thus be hidden. > > */ > > const struct ipa_callback_ops IPAContextWrapper::callbacks_ = { > > .queue_frame_action = &IPAContextWrapper::queue_frame_action, > > -- > > Regards, > > > > Laurent Pinchart > > > > _______________________________________________ > > libcamera-devel mailing list > > libcamera-devel@lists.libcamera.org > > https://lists.libcamera.org/listinfo/libcamera-devel > > -- > Regards, > Niklas Söderlund > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp index 054aa6ba2089..471118f57cdc 100644 --- a/src/libcamera/ipa_context_wrapper.cpp +++ b/src/libcamera/ipa_context_wrapper.cpp @@ -283,7 +283,7 @@ void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame, #ifndef __DOXYGEN__ /* * This construct confuses Doxygen and makes it believe that all members of the - * operations is a member of IPAInterfaceWrapper. It must thus be hidden. + * operations is a member of IPAContextWrapper. It must thus be hidden. */ const struct ipa_callback_ops IPAContextWrapper::callbacks_ = { .queue_frame_action = &IPAContextWrapper::queue_frame_action,
A comment copied from the IPAInterfaceWrapper incorrectly mentions the IPAInterfaceWrapper class instead of the IPAContextWrapper class. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/ipa_context_wrapper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)