[libcamera-devel,v4,14/22] v4l2: v4l2_camera_proxy: noop if streamon when stream is already on

Message ID 20200624145256.48266-15-paul.elder@ideasonboard.com
State Accepted
Headers show
Series
  • Support v4l2-compliance
Related show

Commit Message

Paul Elder June 24, 2020, 2:52 p.m. UTC
If VIDIOC_STREMAON is called when the stream is already on, do a noop.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
No change in v4

Changes in v3:
- move isRunning check to after ownership check

New in v2: (split from "v4l2: v4l2_camera: Add isRunning()")
---
 src/v4l2/v4l2_camera_proxy.cpp | 3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index f8e8d79..7b269a5 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -625,6 +625,9 @@  int V4L2CameraProxy::vidioc_streamon(V4L2CameraFile *file, int *arg)
 	if (!hasOwnership(file))
 		return -EBUSY;
 
+	if (vcam_->isRunning())
+		return 0;
+
 	currentBuf_ = 0;
 
 	return vcam_->streamOn();