| Message ID | 20190326083902.26121-16-jacopo@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Tue, Mar 26, 2019 at 09:38:58AM +0100, Jacopo Mondi wrote: > Implement queueRequest for the IPU3 pipeline manager. When a request is > queued, a new buffer is queued to the ImgU output for capture. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 5b3c44174566..9e8a20849ed0 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -414,9 +414,10 @@ void PipelineHandlerIPU3::stop(Camera *camera) > int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) > { > IPU3CameraData *data = cameraData(camera); > - V4L2Device *cio2 = data->cio2_.output_; > + V4L2Device *output = data->imgu_->output_; > Stream *stream = &data->stream_; > > + /* Queue a buffer to the ImgU output for capture. */ > Buffer *buffer = request->findBuffer(stream); > if (!buffer) { > LOG(IPU3, Error) > @@ -424,7 +425,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) > return -ENOENT; > } > > - int ret = cio2->queueBuffer(buffer); > + int ret = output->queueBuffer(buffer); > if (ret < 0) > return ret; >
Hi Jacopo, Thanks for your work. On 2019-03-26 09:38:58 +0100, Jacopo Mondi wrote: > Implement queueRequest for the IPU3 pipeline manager. When a request is > queued, a new buffer is queued to the ImgU output for capture. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 5b3c44174566..9e8a20849ed0 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -414,9 +414,10 @@ void PipelineHandlerIPU3::stop(Camera *camera) > int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) > { > IPU3CameraData *data = cameraData(camera); > - V4L2Device *cio2 = data->cio2_.output_; > + V4L2Device *output = data->imgu_->output_; > Stream *stream = &data->stream_; > > + /* Queue a buffer to the ImgU output for capture. */ > Buffer *buffer = request->findBuffer(stream); > if (!buffer) { > LOG(IPU3, Error) > @@ -424,7 +425,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) > return -ENOENT; > } > > - int ret = cio2->queueBuffer(buffer); > + int ret = output->queueBuffer(buffer); > if (ret < 0) > return ret; > > -- > 2.21.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 5b3c44174566..9e8a20849ed0 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -414,9 +414,10 @@ void PipelineHandlerIPU3::stop(Camera *camera) int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) { IPU3CameraData *data = cameraData(camera); - V4L2Device *cio2 = data->cio2_.output_; + V4L2Device *output = data->imgu_->output_; Stream *stream = &data->stream_; + /* Queue a buffer to the ImgU output for capture. */ Buffer *buffer = request->findBuffer(stream); if (!buffer) { LOG(IPU3, Error) @@ -424,7 +425,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request) return -ENOENT; } - int ret = cio2->queueBuffer(buffer); + int ret = output->queueBuffer(buffer); if (ret < 0) return ret;
Implement queueRequest for the IPU3 pipeline manager. When a request is queued, a new buffer is queued to the ImgU output for capture. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)