[libcamera-devel,v2,2/4] cam: improve error checking when capturing
diff mbox series

Message ID 20190224171407.7856-3-niklas.soderlund@ragnatech.se
State Accepted
Commit dd14f1ec2cb772d731570df54bbc9e10eae9e018
Headers show
Series
  • cam: improve error paths
Related show

Commit Message

Niklas Söderlund Feb. 24, 2019, 5:14 p.m. UTC 
The return value when start() and stop() the camera should be checked
and handled.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/cam/main.cpp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/src/cam/main.cpp b/src/cam/main.cpp
index b034eb25429abeb3..30267970a2c8485f 100644
--- a/src/cam/main.cpp
+++ b/src/cam/main.cpp
@@ -183,11 +183,18 @@  static int capture()
 	}
 
 	std::cout << "Capture until user interrupts by SIGINT" << std::endl;
-	camera->start();
+
+	ret = camera->start();
+	if (ret) {
+		std::cout << "Failed to start capture" << std::endl;
+		goto out;
+	}
 
 	ret = loop->exec();
 
-	camera->stop();
+	ret = camera->stop();
+	if (ret)
+		std::cout << "Failed to stop capture" << std::endl;
 out:
 	camera->freeBuffers();