[libcamera-devel,04/27] test: v4l2_device: Add request_buffers test
diff mbox series

Message ID 20190206060818.13907-5-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Capture frames throught requests
Related show

Commit Message

Laurent Pinchart Feb. 6, 2019, 6:07 a.m. UTC 
From: Kieran Bingham <kieran.bingham@ideasonboard.com>

Add a utility to the test suite to request and allocate buffers from
a V4L2Device to ensure it functions correctly.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 test/v4l2_device/meson.build         |  1 +
 test/v4l2_device/request_buffers.cpp | 32 ++++++++++++++++++++++++++++
 test/v4l2_device/v4l2_device_test.h  |  7 +++++-
 3 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 test/v4l2_device/request_buffers.cpp

Patch
diff mbox series 

diff --git a/test/v4l2_device/meson.build b/test/v4l2_device/meson.build
index 41675a303498..b6b672611d60 100644
--- a/test/v4l2_device/meson.build
+++ b/test/v4l2_device/meson.build
@@ -2,6 +2,7 @@ 
 # They are not alphabetically sorted.
 v4l2_device_tests = [
   [ 'double_open',        'double_open.cpp' ],
+  [ 'request_buffers',    'request_buffers.cpp' ],
 ]
 
 foreach t : v4l2_device_tests
diff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp
new file mode 100644
index 000000000000..bc6ff2c18a57
--- /dev/null
+++ b/test/v4l2_device/request_buffers.cpp
@@ -0,0 +1,32 @@ 
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2019, Google Inc.
+ *
+ * libcamera V4L2 API tests
+ */
+
+#include "v4l2_device_test.h"
+
+class RequestBuffersTest : public V4L2DeviceTest
+{
+protected:
+	int run()
+	{
+		/*
+		 * TODO:
+		 *  Test invalid requests
+		 *  Test different buffer allocations
+		 */
+		const unsigned int bufferCount = 8;
+
+		createBuffers(bufferCount);
+
+		int ret = dev_->exportBuffers(bufferCount, &pool_);
+		if (ret)
+			return TestFail;
+
+		return TestPass;
+	}
+};
+
+TEST_REGISTER(RequestBuffersTest);
diff --git a/test/v4l2_device/v4l2_device_test.h b/test/v4l2_device/v4l2_device_test.h
index ca231ab47fde..f22f0bb555d8 100644
--- a/test/v4l2_device/v4l2_device_test.h
+++ b/test/v4l2_device/v4l2_device_test.h
@@ -9,6 +9,8 @@ 
 
 #include <memory>
 
+#include <libcamera/buffer.h>
+
 #include "test.h"
 
 #include "device_enumerator.h"
@@ -20,7 +22,9 @@  using namespace libcamera;
 class V4L2DeviceTest : public Test
 {
 public:
-	V4L2DeviceTest() : dev_(nullptr) { };
+	V4L2DeviceTest() : dev_(nullptr){};
+
+	void createBuffers(unsigned int qty) { pool_.createBuffers(qty); }
 
 protected:
 	int init();
@@ -29,6 +33,7 @@  protected:
 	std::unique_ptr<DeviceEnumerator> enumerator_;
 	std::shared_ptr<MediaDevice> media_;
 	V4L2Device *dev_;
+	BufferPool pool_;
 };
 
 #endif /* __LIBCAMERA_V4L2_DEVICE_TEST_H_ */