| Message ID | 20181214090154.32679-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On Friday, 14 December 2018 11:01:54 EET Kieran Bingham wrote: > Provide an initial starting point for our ignore file. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > .gitignore | 4 ++++ > 1 file changed, 4 insertions(+) > create mode 100644 .gitignore > > diff --git a/.gitignore b/.gitignore > new file mode 100644 > index 000000000000..420c8d5cd4df > --- /dev/null > +++ b/.gitignore > @@ -0,0 +1,4 @@ > +build/ > +patches/ I also regularly use a patches directory at the top level :-) > +*.patch > +*.orig I wouldn't add *.orig here. It bothers me that the kernel ignores those files, as they then end up lying around unnoticed until I happen to stumble upon them and delete them. The rest seems fine to me. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Hi Laurent, On 14/12/2018 09:31, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 14 December 2018 11:01:54 EET Kieran Bingham wrote: >> Provide an initial starting point for our ignore file. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> --- >> .gitignore | 4 ++++ >> 1 file changed, 4 insertions(+) >> create mode 100644 .gitignore >> >> diff --git a/.gitignore b/.gitignore >> new file mode 100644 >> index 000000000000..420c8d5cd4df >> --- /dev/null >> +++ b/.gitignore >> @@ -0,0 +1,4 @@ >> +build/ >> +patches/ > > I also regularly use a patches directory at the top level :-) Where else would they go :) > >> +*.patch >> +*.orig > > I wouldn't add *.orig here. It bothers me that the kernel ignores those files, > as they then end up lying around unnoticed until I happen to stumble upon them > and delete them. > Hrm ... I usually also delete them pretty quickly I guess. I'll remove this and push. > The rest seems fine to me. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >
diff --git a/.gitignore b/.gitignore new file mode 100644 index 000000000000..420c8d5cd4df --- /dev/null +++ b/.gitignore @@ -0,0 +1,4 @@ +build/ +patches/ +*.patch +*.orig
Provide an initial starting point for our ignore file. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .gitignore