[libcamera-devel,v3,05/22] v4l2: v4l2_camera_proxy: Clear reserved field in reqbufs
diff mbox series

Message ID 20200623190836.53446-6-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • Support v4l2-compliance
Related show

Commit Message

Paul Elder June 23, 2020, 7:08 p.m. UTC 
Clear the reserved field in arg struct v4l2_reqbuffers of
VIDIOC_REQBUFS.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

---
New in v3
- split from a conglomerate of v4l2-compliance fixes patch
---
 src/v4l2/v4l2_camera_proxy.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart June 23, 2020, 10:27 p.m. UTC | #1 
Hi Paul,

Thank you for the patch.

On Wed, Jun 24, 2020 at 04:08:19AM +0900, Paul Elder wrote:
> Clear the reserved field in arg struct v4l2_reqbuffers of
> VIDIOC_REQBUFS.
> 
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> New in v3
> - split from a conglomerate of v4l2-compliance fixes patch
> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index 7262453..5acb036 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -355,6 +355,7 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf
>  		return ret;
>  
>  	arg->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP;
> +	memset(arg->reserved, 0, sizeof(arg->reserved));
>  
>  	if (arg->count == 0) {
>  		release(file);

Patch
diff mbox series 

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index 7262453..5acb036 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -355,6 +355,7 @@  int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf
 		return ret;
 
 	arg->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP;
+	memset(arg->reserved, 0, sizeof(arg->reserved));
 
 	if (arg->count == 0) {
 		release(file);