[libcamera-devel] Correct small typo in method description

4155 diff mbox series

From: Chris Chinchilla <chris@gregariousmammal.com>

Correct small typo in method description
Fixes: d6a88607479 ("libcamera: pipeline_handler: Keep track of MediaDevice")
Signed-off-by: Chris Chinchilla <chris@gregariousmammal.com>
---
 src/libcamera/pipeline_handler.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Chris,

On 23/06/2020 11:37, chris@gregariousmammal.com wrote:
> From: Chris Chinchilla <chris@gregariousmammal.com>
> 
> Correct small typo in method description

Missing a new line between the commit message and the trailing tags
section. I'll add it while applying.


> Fixes: d6a88607479 ("libcamera: pipeline_handler: Keep track of MediaDevice")
> Signed-off-by: Chris Chinchilla <chris@gregariousmammal.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Thanks.


> ---
>  src/libcamera/pipeline_handler.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index 14dfba0..2eb86ad 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -181,7 +181,7 @@ PipelineHandler::~PipelineHandler()
>   */
>  
>  /**
> - * \brief Search and acquire a MediDevice matching a device pattern
> + * \brief Search and acquire a MediaDevice matching a device pattern
>   * \param[in] enumerator Enumerator containing all media devices in the system
>   * \param[in] dm Device match pattern
>   *
>

Hi Chris,

On 23/06/2020 11:41, Kieran Bingham wrote:
> Hi Chris,
> 
> On 23/06/2020 11:37, chris@gregariousmammal.com wrote:
>> From: Chris Chinchilla <chris@gregariousmammal.com>
>>
>> Correct small typo in method description
> 
> Missing a new line between the commit message and the trailing tags
> section. I'll add it while applying.
> 
> 
>> Fixes: d6a88607479 ("libcamera: pipeline_handler: Keep track of MediaDevice")
>> Signed-off-by: Chris Chinchilla <chris@gregariousmammal.com>

Ahh, this should also be your 'real name'.

I suspect there's a personal preference in using the Chinchilla ... but
the 'Signed-off-by' tags are sort of a legal-declaration for licencing
purposes.

--
Kieran

> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Thanks.
> 
> 
>> ---
>>  src/libcamera/pipeline_handler.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
>> index 14dfba0..2eb86ad 100644
>> --- a/src/libcamera/pipeline_handler.cpp
>> +++ b/src/libcamera/pipeline_handler.cpp
>> @@ -181,7 +181,7 @@ PipelineHandler::~PipelineHandler()
>>   */
>>  
>>  /**
>> - * \brief Search and acquire a MediDevice matching a device pattern
>> + * \brief Search and acquire a MediaDevice matching a device pattern
>>   * \param[in] enumerator Enumerator containing all media devices in the system
>>   * \param[in] dm Device match pattern
>>   *
>>
>

I don’t mind either way, my legal name is “Chris Ward”, but I have used “Chris Chinchilla” as a moniker/nickname since about 1998 especially on git and open source projects. I do have legal evidence to show it as a recognisable alias if it’s ever needed, mostly because I have used it for so long. For example, when I was a musician I also used it as an alias, and have it registered as an alias with the Uk collection society etc…

But if it’s really an issue and you’d feel happier with me not using it, I really don’t mind, was just force of habit and how my git identity is set up :)

Hi Chris,

Thank you for the patch.

On Tue, Jun 23, 2020 at 12:37:54PM +0200, chris@gregariousmammal.com wrote:
> From: Chris Chinchilla <chris@gregariousmammal.com>
> 
> Correct small typo in method description

With a blank line added here,

> Fixes: d6a88607479 ("libcamera: pipeline_handler: Keep track of MediaDevice")
> Signed-off-by: Chris Chinchilla <chris@gregariousmammal.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline_handler.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index 14dfba0..2eb86ad 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -181,7 +181,7 @@ PipelineHandler::~PipelineHandler()
>   */
>  
>  /**
> - * \brief Search and acquire a MediDevice matching a device pattern
> + * \brief Search and acquire a MediaDevice matching a device pattern
>   * \param[in] enumerator Enumerator containing all media devices in the system
>   * \param[in] dm Device match pattern
>   *

Hi Chris,

On Tue, Jun 23, 2020 at 12:55:28PM +0200, Chris Chinchilla wrote:
> I don’t mind either way, my legal name is “Chris Ward”, but I have used “Chris
> Chinchilla” as a moniker/nickname since about 1998 especially on git and open
> source projects. I do have legal evidence to show it as a recognisable alias if
> it’s ever needed, mostly because I have used it for so long. For example, when
> I was a musician I also used it as an alias, and have it registered as an alias
> with the Uk collection society etc… 
> 
> But if it’s really an issue and you’d feel happier with me not using it, I
> really don’t mind, was just force of habit and how my git identity is set up :)

I don't have a strong opinion on this topic. The Linux kernel patch
submission rules say you have to use your "real name" in a Signed-off-by
tag:

"... using your real name (sorry, no pseudonyms or anonymous contributions.)"

I think we should apply the same policy, but the document fails short of
defining what a "real name" is. Anonymous contributions are easy to
understand, pseudonym less so. I believe the rationale here is to ensure
that contributions can be attributed to a person. For that prupose, both
the name on one's passport, and the name that one is called by in real
life, would be acceptable.

If someone knows of official policies in this regard that could be
applicable to libcamera, that could be useful. I will also ask around.