[libcamera-devel,v2,1/4] libcamera: add a sharpness strength control

Message ID 20200622135550.10788-2-david.plowman@raspberrypi.com
State Superseded
Headers show
Series
  • libcamera sharpness strength control
Related show

Commit Message

David Plowman June 22, 2020, 1:55 p.m. UTC
The control is a single float value with minimum, default and maximum
values. Please read the description for more details.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/libcamera/control_ids.yaml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Laurent Pinchart June 22, 2020, 10:35 p.m. UTC | #1
Hi David,

Thank you for the patch.

On Mon, Jun 22, 2020 at 02:55:47PM +0100, David Plowman wrote:
> The control is a single float value with minimum, default and maximum
> values. Please read the description for more details.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/control_ids.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 77ebc3f..8c3e4c7 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -239,4 +239,16 @@ controls:
>          pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels
>          control can only be returned in metadata.
>        size: [4]
> +
> +  - Sharpness:
> +      type: float
> +      description:  |
> +        A value of 0.0 means no sharpening. The minimum value means
> +        minimal sharpening, and shall be 0.0 unless the camera can't
> +        disable sharpening completely. The default value shall give a
> +        "reasonable" level of sharpening, suitable for most use cases.
> +        The maximum value may apply extremely high levels of sharpening,
> +        higher than anyone could reasonably want. Negative values are
> +        not allowed. Note also that sharpening is not applied to raw
> +        streams.
>  ...

Patch

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 77ebc3f..8c3e4c7 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -239,4 +239,16 @@  controls:
         pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels
         control can only be returned in metadata.
       size: [4]
+
+  - Sharpness:
+      type: float
+      description:  |
+        A value of 0.0 means no sharpening. The minimum value means
+        minimal sharpening, and shall be 0.0 unless the camera can't
+        disable sharpening completely. The default value shall give a
+        "reasonable" level of sharpening, suitable for most use cases.
+        The maximum value may apply extremely high levels of sharpening,
+        higher than anyone could reasonably want. Negative values are
+        not allowed. Note also that sharpening is not applied to raw
+        streams.
 ...