[libcamera-devel] meson: detect kernel version

4022 diff mbox series

Add kernel version detection to warn user
that only >= 5.0.0 V4L API are supported in
libcamera.

Signed-off-by: Stéphane Cerveau <scerveau@collabora.com>
---
 meson.build | 9 +++++++++
 1 file changed, 9 insertions(+)

Hi Stéphane,

On 11/06/2020 10:33, Stéphane Cerveau wrote:
> Add kernel version detection to warn user
> that only >= 5.0.0 V4L API are supported in
> libcamera.

When you post sequential versions of a patch, could you put the patch
version in $SUBJECT please?

I think this is now ... PATCH v4 ?

Use -v5 when you do git format-patch next


> Signed-off-by: Stéphane Cerveau <scerveau@collabora.com>
> ---
>  meson.build | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index e898782..5ac9039 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -105,6 +105,15 @@ if get_option('test')
>      subdir('test')
>  endif
>  
> +if not meson.is_cross_build()
> +  kernel_version_req = '>= 6.0.0'

Ahem ... (I was doing the same to test too :-D )

> +  kernel_version = run_command('uname', '-r').stdout()
> +  if not kernel_version.version_compare(kernel_version_req)
> +    warning('Consider upgrading your kernel, as only @0@ is supported by libcamera at runtime'
> +            .format(kernel_version_req))

Aha, I guess that solves the newline issue, and shortens ;-)

Fine by me anyway.

With the kernel_version_req fixed,

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

But I'll wait for Laurent to comment before applying (if he's happy I
can fix the kernel_version_req when applying).

> +  endif
> +endif
> +
>  # Create a symlink from the build root to the source root. This is used when
>  # running libcamera from the build directory to locate resources in the source
>  # directory (such as IPA configuration files).
>