| Message ID | 20200604090503.3779724-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 4bd25c6f51b951b8608c027f0706dc23f31fd773 |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On Thu, Jun 04, 2020 at 10:05:03AM +0100, Kieran Bingham wrote: > The DRM(BGRA8888)/V4L2(ARGB8888) format is not supported by the debayer > unit at all in VIMC. That's not where it should be supported though, conversion to different RGB formats should happen at the (virtual) DMA level. Regardless, I agree it's not supported by the driver, so the patch is fine. With an update of the commit message, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Remove it from the list of supported configurations. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/vimc/vimc.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp > index 914df3476eb9..9952e36b016d 100644 > --- a/src/libcamera/pipeline/vimc/vimc.cpp > +++ b/src/libcamera/pipeline/vimc/vimc.cpp > @@ -110,7 +110,6 @@ namespace { > static const std::map<PixelFormat, uint32_t> pixelformats{ > { PixelFormat(DRM_FORMAT_RGB888), MEDIA_BUS_FMT_BGR888_1X24 }, > { PixelFormat(DRM_FORMAT_BGR888), MEDIA_BUS_FMT_RGB888_1X24 }, > - { PixelFormat(DRM_FORMAT_BGRA8888), MEDIA_BUS_FMT_ARGB8888_1X32 }, > }; > > } /* namespace */
On 04/06/2020 10:09, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Jun 04, 2020 at 10:05:03AM +0100, Kieran Bingham wrote: >> The DRM(BGRA8888)/V4L2(ARGB8888) format is not supported by the debayer >> unit at all in VIMC. > > That's not where it should be supported though, conversion to different > RGB formats should happen at the (virtual) DMA level. Regardless, I > agree it's not supported by the driver, so the patch is fine. With an > update of the commit message, > "The DRM(BGRA8888)/V4L2(ARGB8888) format is not supported at all in VIMC. Remove it." > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Remove it from the list of supported configurations. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> --- >> src/libcamera/pipeline/vimc/vimc.cpp | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp >> index 914df3476eb9..9952e36b016d 100644 >> --- a/src/libcamera/pipeline/vimc/vimc.cpp >> +++ b/src/libcamera/pipeline/vimc/vimc.cpp >> @@ -110,7 +110,6 @@ namespace { >> static const std::map<PixelFormat, uint32_t> pixelformats{ >> { PixelFormat(DRM_FORMAT_RGB888), MEDIA_BUS_FMT_BGR888_1X24 }, >> { PixelFormat(DRM_FORMAT_BGR888), MEDIA_BUS_FMT_RGB888_1X24 }, >> - { PixelFormat(DRM_FORMAT_BGRA8888), MEDIA_BUS_FMT_ARGB8888_1X32 }, >> }; >> >> } /* namespace */ >
diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 914df3476eb9..9952e36b016d 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -110,7 +110,6 @@ namespace { static const std::map<PixelFormat, uint32_t> pixelformats{ { PixelFormat(DRM_FORMAT_RGB888), MEDIA_BUS_FMT_BGR888_1X24 }, { PixelFormat(DRM_FORMAT_BGR888), MEDIA_BUS_FMT_RGB888_1X24 }, - { PixelFormat(DRM_FORMAT_BGRA8888), MEDIA_BUS_FMT_ARGB8888_1X32 }, }; } /* namespace */
The DRM(BGRA8888)/V4L2(ARGB8888) format is not supported by the debayer unit at all in VIMC. Remove it from the list of supported configurations. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/libcamera/pipeline/vimc/vimc.cpp | 1 - 1 file changed, 1 deletion(-)