| Message ID | 20200518095558.6488-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Superseded |
| Delegated to: | Laurent Pinchart |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 18/05/2020 10:55, Laurent Pinchart wrote: > The buffer_writer.h header is not part of the libcamera core, rename the > header guard from __LIBCAMERA_BUFFER_WRITER_H__ to > __CAM_BUFFER_WRITER_H__. > Was this a one off? or are there more? Perhaps take a look in qcam too ;-) Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/cam/buffer_writer.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h > index 8c9b2436fdae..47e26103e13e 100644 > --- a/src/cam/buffer_writer.h > +++ b/src/cam/buffer_writer.h > @@ -4,8 +4,8 @@ > * > * buffer_writer.h - Buffer writer > */ > -#ifndef __LIBCAMERA_BUFFER_WRITER_H__ > -#define __LIBCAMERA_BUFFER_WRITER_H__ > +#ifndef __CAM_BUFFER_WRITER_H__ > +#define __CAM_BUFFER_WRITER_H__ > > #include <map> > #include <string> > @@ -28,4 +28,4 @@ private: > std::map<int, std::pair<void *, unsigned int>> mappedBuffers_; > }; > > -#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */ > +#endif /* __CAM_BUFFER_WRITER_H__ */ >
diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h index 8c9b2436fdae..47e26103e13e 100644 --- a/src/cam/buffer_writer.h +++ b/src/cam/buffer_writer.h @@ -4,8 +4,8 @@ * * buffer_writer.h - Buffer writer */ -#ifndef __LIBCAMERA_BUFFER_WRITER_H__ -#define __LIBCAMERA_BUFFER_WRITER_H__ +#ifndef __CAM_BUFFER_WRITER_H__ +#define __CAM_BUFFER_WRITER_H__ #include <map> #include <string> @@ -28,4 +28,4 @@ private: std::map<int, std::pair<void *, unsigned int>> mappedBuffers_; }; -#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */ +#endif /* __CAM_BUFFER_WRITER_H__ */
The buffer_writer.h header is not part of the libcamera core, rename the header guard from __LIBCAMERA_BUFFER_WRITER_H__ to __CAM_BUFFER_WRITER_H__. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/cam/buffer_writer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)