[libcamera-devel,v10,01/13] dt-bindings: video-interfaces: Document 'orientation' property

Message ID 20200508100158.3437161-2-jacopo@jmondi.org
State Superseded
Headers show
Series
  • media: report camera properties
Related show

Commit Message

Jacopo Mondi May 8, 2020, 10:01 a.m. UTC
Add the 'orientation' device property, used to specify the device mounting
position. The property is particularly meaningful for mobile devices
with a well defined usage orientation.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 .../devicetree/bindings/media/video-interfaces.txt    | 11 +++++++++++
 1 file changed, 11 insertions(+)

--
2.26.1

Comments

Rob Herring May 11, 2020, 5:20 p.m. UTC | #1
On Fri,  8 May 2020 12:01:46 +0200, Jacopo Mondi wrote:
> Add the 'orientation' device property, used to specify the device mounting
> position. The property is particularly meaningful for mobile devices
> with a well defined usage orientation.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  .../devicetree/bindings/media/video-interfaces.txt    | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Jacopo Mondi May 12, 2020, 7:21 a.m. UTC | #2
Hi Rob,

On Mon, May 11, 2020 at 12:20:08PM -0500, Rob Herring wrote:
> On Fri,  8 May 2020 12:01:46 +0200, Jacopo Mondi wrote:
> > Add the 'orientation' device property, used to specify the device mounting
> > position. The property is particularly meaningful for mobile devices
> > with a well defined usage orientation.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  .../devicetree/bindings/media/video-interfaces.txt    | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>

Yours and Tomasz's tags are back in v11, for which Hans has sent a
pull request.

Sorry I've missed them in v10, not sure what happened :)

Thanks
   j

> If a tag was not added on purpose, please state why and what changed.
>

Patch

diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
index f884ada0bffc8..b1ff492c7da7a 100644
--- a/Documentation/devicetree/bindings/media/video-interfaces.txt
+++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
@@ -89,6 +89,17 @@  Optional properties
   but a number of degrees counter clockwise. Typical values are 0 and 180
   (upside down).

+- orientation: The orientation of a device (typically an image sensor or a flash
+  LED) describing its mounting position relative to the usage orientation of the
+  system where the device is installed on.
+  Possible values are:
+  0 - Front. The device is mounted on the front facing side of the system.
+  For mobile devices such as smartphones, tablets and laptops the front side is
+  the user facing side.
+  1 - Back. The device is mounted on the back side of the system, which is
+  defined as the opposite side of the front facing one.
+  2 - External. The device is not attached directly to the system but is
+  attached in a way that allows it to move freely.

 Optional endpoint properties
 ----------------------------