[libcamera-devel,PATCH/RFC] libcamera: proxy: Relicense proxy worker under LGPL

Message ID 20200508013518.7625-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit cc8215f3819279678731727087acabd2f17c9412
Headers show
Series
  • [libcamera-devel,PATCH/RFC] libcamera: proxy: Relicense proxy worker under LGPL
Related show

Commit Message

Laurent Pinchart May 8, 2020, 1:35 a.m. UTC
The proxy worker is licensed under the GPL. It is compiled as a binary
separate from libcamera.so, and it is our understanding and intent that
the GPL license doesn't propagate to libcamera.so. However, as the
worker is executed by libcamera.so, the GPL license may cause concerns
in this context, regardless of whether the concerns are valid or not.

This uncertainty could be addressed by a combination of a legal review
and an explicit intent clarification from the copyright holders. A
simpler option is to relicense the code under the LGPL.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund May 10, 2020, 8:52 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2020-05-08 04:35:18 +0300, Laurent Pinchart wrote:
> The proxy worker is licensed under the GPL. It is compiled as a binary
> separate from libcamera.so, and it is our understanding and intent that
> the GPL license doesn't propagate to libcamera.so. However, as the
> worker is executed by libcamera.so, the GPL license may cause concerns
> in this context, regardless of whether the concerns are valid or not.
> 
> This uncertainty could be addressed by a combination of a legal review
> and an explicit intent clarification from the copyright holders. A
> simpler option is to relicense the code under the LGPL.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> index 7d6287c7115b..9cefa2405e19 100644
> --- a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> +++ b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Kieran Bingham May 11, 2020, 8:14 a.m. UTC | #2
Hi Laurent,

On 08/05/2020 02:35, Laurent Pinchart wrote:
> The proxy worker is licensed under the GPL. It is compiled as a binary
> separate from libcamera.so, and it is our understanding and intent that
> the GPL license doesn't propagate to libcamera.so. However, as the
> worker is executed by libcamera.so, the GPL license may cause concerns
> in this context, regardless of whether the concerns are valid or not.
> 
> This uncertainty could be addressed by a combination of a legal review
> and an explicit intent clarification from the copyright holders. A
> simpler option is to relicense the code under the LGPL.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

This file was created by Paul, and also has a modification from Jacopo,
so lets try to get their explicit Ack, but this is fine with me.

Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> index 7d6287c7115b..9cefa2405e19 100644
> --- a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> +++ b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
>
Jacopo Mondi May 11, 2020, 8:35 a.m. UTC | #3
Hello,

On Mon, May 11, 2020 at 09:14:03AM +0100, Kieran Bingham wrote:
> Hi Laurent,
>
> On 08/05/2020 02:35, Laurent Pinchart wrote:
> > The proxy worker is licensed under the GPL. It is compiled as a binary
> > separate from libcamera.so, and it is our understanding and intent that
> > the GPL license doesn't propagate to libcamera.so. However, as the
> > worker is executed by libcamera.so, the GPL license may cause concerns
> > in this context, regardless of whether the concerns are valid or not.
> >
> > This uncertainty could be addressed by a combination of a legal review
> > and an explicit intent clarification from the copyright holders. A
> > simpler option is to relicense the code under the LGPL.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> This file was created by Paul, and also has a modification from Jacopo,
> so lets try to get their explicit Ack, but this is fine with me.
>
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>From my side:
Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

>
> > ---
> >  src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> > index 7d6287c7115b..9cefa2405e19 100644
> > --- a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> > +++ b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */
> >  /*
> >   * Copyright (C) 2019, Google Inc.
> >   *
> >
>
> --
> Regards
> --
> Kieran
Paul Elder May 12, 2020, 5:56 p.m. UTC | #4
On Mon, May 11, 2020 at 09:14:03AM +0100, Kieran Bingham wrote:
> Hi Laurent,
> 
> On 08/05/2020 02:35, Laurent Pinchart wrote:
> > The proxy worker is licensed under the GPL. It is compiled as a binary
> > separate from libcamera.so, and it is our understanding and intent that
> > the GPL license doesn't propagate to libcamera.so. However, as the
> > worker is executed by libcamera.so, the GPL license may cause concerns
> > in this context, regardless of whether the concerns are valid or not.
> > 
> > This uncertainty could be addressed by a combination of a legal review
> > and an explicit intent clarification from the copyright holders. A
> > simpler option is to relicense the code under the LGPL.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> This file was created by Paul, and also has a modification from Jacopo,
> so lets try to get their explicit Ack, but this is fine with me.
> 
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Looks good to me.

Acked-by: Paul Elder <paul.elder@ideasonboard.com>


Paul

Patch

diff --git a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
index 7d6287c7115b..9cefa2405e19 100644
--- a/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
+++ b/src/libcamera/proxy/worker/ipa_proxy_linux_worker.cpp
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2019, Google Inc.
  *