| Message ID | 20200503002723.1367196-1-niklas.soderlund@ragnatech.se |
|---|---|
| State | Accepted |
| Commit | f5698ed541a424befa7258ecb459ec44e406fdb5 |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, Thank you for the patch. On Sun, May 03, 2020 at 02:27:23AM +0200, Niklas Söderlund wrote: > Todo statements should not end with a colon, remove it. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/qcam/dng_writer.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp > index 7d51965dc2ea3201..f0d6f5f473e3d680 100644 > --- a/src/qcam/dng_writer.cpp > +++ b/src/qcam/dng_writer.cpp > @@ -47,7 +47,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width) > const uint8_t *in = static_cast<const uint8_t *>(input); > uint8_t *out = static_cast<uint8_t *>(output); > > - /* \todo: Can this be made more efficient? */ > + /* \todo Can this be made more efficient? */ > for (unsigned int i = 0; i < width; i += 2) { > *out++ = in[0]; > *out++ = (in[2] & 0x0f) << 4 | in[1] >> 4;
diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp index 7d51965dc2ea3201..f0d6f5f473e3d680 100644 --- a/src/qcam/dng_writer.cpp +++ b/src/qcam/dng_writer.cpp @@ -47,7 +47,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width) const uint8_t *in = static_cast<const uint8_t *>(input); uint8_t *out = static_cast<uint8_t *>(output); - /* \todo: Can this be made more efficient? */ + /* \todo Can this be made more efficient? */ for (unsigned int i = 0; i < width; i += 2) { *out++ = in[0]; *out++ = (in[2] & 0x0f) << 4 | in[1] >> 4;
Todo statements should not end with a colon, remove it. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- src/qcam/dng_writer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)