[libcamera-devel] qcam: DNGWriter: Fix missing field name

Message ID 20200502212643.1281485-1-niklas.soderlund@ragnatech.se
State Accepted
Commit a0d8a9ec956cdf35ccfc4f01cfc166103a7a7bcf
Headers show
Series
  • [libcamera-devel] qcam: DNGWriter: Fix missing field name
Related show

Commit Message

Niklas Söderlund May 2, 2020, 9:26 p.m. UTC
While reformatting the table the field name was missed for one entry,
add it.

Fixes: db7235b7141aa4e2 ("qcam: Add DNGWriter")
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/qcam/dng_writer.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart May 2, 2020, 9:52 p.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Sat, May 02, 2020 at 11:26:43PM +0200, Niklas Söderlund wrote:
> While reformatting the table the field name was missed for one entry,
> add it.
> 
> Fixes: db7235b7141aa4e2 ("qcam: Add DNGWriter")
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

I have the same fix in my tree :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/qcam/dng_writer.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp
> index 08078369529bb780..7d51965dc2ea3201 100644
> --- a/src/qcam/dng_writer.cpp
> +++ b/src/qcam/dng_writer.cpp
> @@ -65,7 +65,7 @@ static const std::map<PixelFormat, FormatInfo> formatInfo = {
>  	{ PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED), {
>  		.bitsPerSample = 10,
>  		.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },
> -		packScanlineSBGGR10P,
> +		.packScanline = packScanlineSBGGR10P,
>  	} },
>  	{ PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED), {
>  		.bitsPerSample = 10,

Patch

diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp
index 08078369529bb780..7d51965dc2ea3201 100644
--- a/src/qcam/dng_writer.cpp
+++ b/src/qcam/dng_writer.cpp
@@ -65,7 +65,7 @@  static const std::map<PixelFormat, FormatInfo> formatInfo = {
 	{ PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED), {
 		.bitsPerSample = 10,
 		.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },
-		packScanlineSBGGR10P,
+		.packScanline = packScanlineSBGGR10P,
 	} },
 	{ PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED), {
 		.bitsPerSample = 10,