[libcamera-devel,v2,2/2] test: log: log_api: Close open fds on error paths
diff mbox series

Message ID 20200415150409.27938-3-email@uajain.com
State Accepted
Headers show
Series
  • Coverity scans fixes
Related show

Commit Message

Umang Jain April 15, 2020, 3:04 p.m. UTC 
Pointed out by Coverity DefectId=279091

Signed-off-by: Umang Jain <email@uajain.com>
---
 test/log/log_api.cpp | 2 ++
 1 file changed, 2 insertions(+)

Patch
diff mbox series 

diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp
index 33622f8..4d2c8db 100644
--- a/test/log/log_api.cpp
+++ b/test/log/log_api.cpp
@@ -86,6 +86,7 @@  protected:
 
 		if (logSetFile(path) < 0) {
 			cerr << "Failed to set log file" << endl;
+			close(fd);
 			return TestFail;
 		}
 
@@ -96,6 +97,7 @@  protected:
 		lseek(fd, 0, SEEK_SET);
 		if (read(fd, buf, sizeof(buf)) < 0) {
 			cerr << "Failed to read tmp log file" << endl;
+			close(fd);
 			return TestFail;
 		}
 		close(fd);