[libcamera-devel,RFCv2,3/7] libcamera: pipeline: rkisp1: Initialize IPA
diff mbox series

Message ID 20200326160819.4088361-4-niklas.soderlund@ragnatech.se
State Superseded
Headers show
Series
  • libcamera: ipa_manager: Proxy open-source IPAs to a thread
Related show

Commit Message

Niklas Söderlund March 26, 2020, 4:08 p.m. UTC 
The IPA init() call is a no-op in the current IPA, but it's part of the
IPA API and it should be called.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++
 1 file changed, 2 insertions(+)

Comments

Laurent Pinchart March 26, 2020, 4:53 p.m. UTC | #1 
Hi Niklas,

Thank you for the patch.

On Thu, Mar 26, 2020 at 05:08:15PM +0100, Niklas Söderlund wrote:
> The IPA init() call is a no-op in the current IPA, but it's part of the
> IPA API and it should be called.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 4ec74c5aa8286ffb..f64807984519779b 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -386,6 +386,8 @@ int RkISP1CameraData::loadIPA()
>  	ipa_->queueFrameAction.connect(this,
>  				       &RkISP1CameraData::queueFrameAction);
>  
> +	ipa_->init();
> +
>  	return 0;
>  }
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 4ec74c5aa8286ffb..f64807984519779b 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -386,6 +386,8 @@  int RkISP1CameraData::loadIPA()
 	ipa_->queueFrameAction.connect(this,
 				       &RkISP1CameraData::queueFrameAction);
 
+	ipa_->init();
+
 	return 0;
 }