[libcamera-devel,v4,2/6] libcamera: properties: Define 'lens' properties

Message ID 20200326145927.324919-3-jacopo@jmondi.org
State RFC
Delegated to: Jacopo Mondi
Headers show
Series
  • Camera properties and camera sensor factory
Related show

Commit Message

Jacopo Mondi March 26, 2020, 2:59 p.m. UTC
Define properties that describe the optical characteristics of the image
sensor.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

Niklas Söderlund April 7, 2020, 10:56 p.m. UTC | #1
Hi Jacopo,

Thanks for your work.

On 2020-03-26 15:59:23 +0100, Jacopo Mondi wrote:
> Define properties that describe the optical characteristics of the image
> sensor.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index ea9d363fdef8..a7897bc8e5dc 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -541,4 +541,38 @@ controls:
>          The range of supported ISO sensitivities, as documented by the
>          ISO 12232:2006 (or later) standard.
>  
> +  - LensApertures:
> +      type: float
> +      size: [n]
> +      description: |
> +        The available lens apertures, expressed as f numbers (the ratio between
> +        the lens focal distance and the diameter of the pupil aperture).
> +
> +        If the camera module has a fixed aperture, the property transports a
> +        single value.
> +
> +  - LensFocalLengths:
> +      type: float
> +      size: [n]
> +      description: |
> +        The available lens focal lengths, expressed in millimeters.
> +
> +        If the camera module supports multiple focal lengths this property
> +        reports the focal lengths associated with each discrete step. For
> +        camera modules with a single focal length, a single value should be
> +        instead reported.
> +
> +  - LensHyperfocalDistances:
> +      type: float
> +      size: [n]
> +      description: |
> +        The hyperfocal distance of the camera module. The property is
> +        particularly meaningful for modules with a single focal length.
> +
> +  - LensMinimumFocusDistance:
> +      type: float
> +      description: |
> +        The shortest distance in millimeters at which an object could be brought
> +        into sharp focus.
> +
>  ...
> -- 
> 2.25.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
index ea9d363fdef8..a7897bc8e5dc 100644
--- a/src/libcamera/property_ids.yaml
+++ b/src/libcamera/property_ids.yaml
@@ -541,4 +541,38 @@  controls:
         The range of supported ISO sensitivities, as documented by the
         ISO 12232:2006 (or later) standard.
 
+  - LensApertures:
+      type: float
+      size: [n]
+      description: |
+        The available lens apertures, expressed as f numbers (the ratio between
+        the lens focal distance and the diameter of the pupil aperture).
+
+        If the camera module has a fixed aperture, the property transports a
+        single value.
+
+  - LensFocalLengths:
+      type: float
+      size: [n]
+      description: |
+        The available lens focal lengths, expressed in millimeters.
+
+        If the camera module supports multiple focal lengths this property
+        reports the focal lengths associated with each discrete step. For
+        camera modules with a single focal length, a single value should be
+        instead reported.
+
+  - LensHyperfocalDistances:
+      type: float
+      size: [n]
+      description: |
+        The hyperfocal distance of the camera module. The property is
+        particularly meaningful for modules with a single focal length.
+
+  - LensMinimumFocusDistance:
+      type: float
+      description: |
+        The shortest distance in millimeters at which an object could be brought
+        into sharp focus.
+
 ...