| Message ID | 20200326114046.4047211-1-niklas.soderlund@ragnatech.se |
|---|---|
| State | Accepted |
| Commit | 6f553040fddd35cd8d59d033bed4ab1b9c2dd634 |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, Thank you for the patch. On Thu, Mar 26, 2020 at 12:40:46PM +0100, Niklas Söderlund wrote: > When changing the VIMC IPA source file structure the path in the > ipa_module_test which needs access to the .so file was not updated, fix > that. > > The omission was hard to spot as it requires a clean build of the > project as the old .so file is still in the build tree and the test > passes. > > Fixes: a25533089bda04da ("ipa: Move vimc to a subdirectory") > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Oops :-S Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/ipa/ipa_module_test.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp > index 3a634099a550fb24..287e53fdaa8e9fad 100644 > --- a/test/ipa/ipa_module_test.cpp > +++ b/test/ipa/ipa_module_test.cpp > @@ -62,7 +62,7 @@ protected: > "GPL-2.0-or-later", > }; > > - count += runTest("src/ipa/ipa_vimc.so", testInfo); > + count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo); > > if (count < 0) > return TestFail;
Hi Niklas, On 26/03/2020 11:40, Niklas Söderlund wrote: > When changing the VIMC IPA source file structure the path in the > ipa_module_test which needs access to the .so file was not updated, fix > that. > > The omission was hard to spot as it requires a clean build of the > project as the old .so file is still in the build tree and the test > passes. > Ooops. Lets get this in soon then :-) Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Fixes: a25533089bda04da ("ipa: Move vimc to a subdirectory") > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > test/ipa/ipa_module_test.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp > index 3a634099a550fb24..287e53fdaa8e9fad 100644 > --- a/test/ipa/ipa_module_test.cpp > +++ b/test/ipa/ipa_module_test.cpp > @@ -62,7 +62,7 @@ protected: > "GPL-2.0-or-later", > }; > > - count += runTest("src/ipa/ipa_vimc.so", testInfo); > + count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo); > > if (count < 0) > return TestFail; >
diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp index 3a634099a550fb24..287e53fdaa8e9fad 100644 --- a/test/ipa/ipa_module_test.cpp +++ b/test/ipa/ipa_module_test.cpp @@ -62,7 +62,7 @@ protected: "GPL-2.0-or-later", }; - count += runTest("src/ipa/ipa_vimc.so", testInfo); + count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo); if (count < 0) return TestFail;
When changing the VIMC IPA source file structure the path in the ipa_module_test which needs access to the .so file was not updated, fix that. The omission was hard to spot as it requires a clean build of the project as the old .so file is still in the build tree and the test passes. Fixes: a25533089bda04da ("ipa: Move vimc to a subdirectory") Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- test/ipa/ipa_module_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)