[libcamera-devel] test: file-descriptor: Fix undefined O_TMPFILE compilation error

Message ID 20200307212530.28053-2-laurent.pinchart@ideasonboard.com
State Accepted
Commit 291d4878bba51603f875257d5b6b3c99b62b6685
Headers show
Series
  • [libcamera-devel] test: file-descriptor: Fix undefined O_TMPFILE compilation error
Related show

Commit Message

Laurent Pinchart March 7, 2020, 9:25 p.m. UTC
O_TMPFILE is not defined by all libc implementations. libcamera has an
internal definition in utils.h to work around this. Include utils.h in
the test to fix the compilation error.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 test/file-descriptor.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Niklas Söderlund March 8, 2020, 4:42 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2020-03-07 23:25:29 +0200, Laurent Pinchart wrote:
> O_TMPFILE is not defined by all libc implementations. libcamera has an
> internal definition in utils.h to work around this. Include utils.h in
> the test to fix the compilation error.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  test/file-descriptor.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp
> index 3e5e880093e7..e467f3a7145e 100644
> --- a/test/file-descriptor.cpp
> +++ b/test/file-descriptor.cpp
> @@ -14,6 +14,7 @@
>  #include <libcamera/file_descriptor.h>
>  
>  #include "test.h"
> +#include "utils.h"
>  
>  using namespace libcamera;
>  using namespace std;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp
index 3e5e880093e7..e467f3a7145e 100644
--- a/test/file-descriptor.cpp
+++ b/test/file-descriptor.cpp
@@ -14,6 +14,7 @@ 
 #include <libcamera/file_descriptor.h>
 
 #include "test.h"
+#include "utils.h"
 
 using namespace libcamera;
 using namespace std;