[v4,3/4] libcamera: camera_sensor: Add properties and helpers for Sony IMX585 and IMX676
diff mbox series

Message ID 20261118-mainline-imx676-v4-3-48ae007f11b4@ideasonboard.com
State New
Headers show
Series
  • libcamera: sensor: Add support for Sony IMX585, IMX675, IMX676, IMX832
Related show

Commit Message

Jai Luthra Nov. 18, 2026, 8:08 a.m. UTC
Sony IMX585 (8.4MP) and IMX676 (12.6MP) are Starvis 2 sensors, with
similar properties to the rest. Add camera sensor properties for both.

While they share the gain model with others, they differ on the minimum
value for the shutter register (SHR0), which is 8 instead of 4. So
define a separate camera sensor helper class to support these two
sensors with exposure margin of 8.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp           | 17 +++++++++++++++++
 src/libcamera/sensor/camera_sensor_properties.cpp | 20 ++++++++++++++++++++
 2 files changed, 37 insertions(+)

Patch
diff mbox series

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 770fc474254d..c5c8a447567f 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -702,6 +702,23 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx477, "imx477")
 
+/*
+ * Reusing CameraSensorHelperImx585 for multiple sensors, for convenience.
+ * They may need to be split apart if any differences are found later.
+ */
+class CameraSensorHelperImx585 : public CameraSensorHelper
+{
+public:
+	CameraSensorHelperImx585()
+	{
+		/* From datasheet: 0x32 at 10bits. */
+		blackLevel_ = 3200;
+		gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };
+		exposureMargin_ = 8;
+	}
+};
+REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx585, "imx585", "imx676")
+
 /*
  * Reusing CameraSensorHelperImx678 for multiple sensors, for convenience.
  * They may need to be split apart if any differences are found later.
diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
index 9dde76937a28..fbe82d47bd10 100644
--- a/src/libcamera/sensor/camera_sensor_properties.cpp
+++ b/src/libcamera/sensor/camera_sensor_properties.cpp
@@ -340,6 +340,16 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 				.hblankDelay = 3
 			},
 		} },
+		{ "imx585", {
+			.unitCellSize = { 2900, 2900 },
+			.testPatternModes = {},
+			.sensorDelays = {
+				.exposureDelay = 2,
+				.gainDelay = 2,
+				.vblankDelay = 2,
+				.hblankDelay = 2
+			},
+		} },
 		{ "imx662", {
 			.unitCellSize = { 2900, 2900 },
 			.testPatternModes = {},
@@ -360,6 +370,16 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 				.hblankDelay = 2
 			},
 		} },
+		{ "imx676", {
+			.unitCellSize = { 2000, 2000 },
+			.testPatternModes = {},
+			.sensorDelays = {
+				.exposureDelay = 2,
+				.gainDelay = 2,
+				.vblankDelay = 2,
+				.hblankDelay = 2
+			},
+		} },
 		{ "imx678", {
 			.unitCellSize = { 2000, 2000 },
 			.testPatternModes = {},