libcamera: controls: Set the ColourTemperature direction to inout
diff mbox series

Message ID 20261112102327.80524-1-naush@raspberrypi.com
State New
Headers show
Series
  • libcamera: controls: Set the ColourTemperature direction to inout
Related show

Commit Message

Naushir Patuck Nov. 12, 2026, 10:23 a.m. UTC
This control is now writable, so fix the direction to inout.

Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable")
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/control_ids_core.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Barnabás Pőcze Nov. 12, 2026, 10:38 a.m. UTC | #1
2026. 11. 12. 11:23 keltezéssel, Naushir Patuck írta:
> This control is now writable, so fix the direction to inout.
> 
> Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable")
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/libcamera/control_ids_core.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 73643e7e84ae..6504f983faa6 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -602,7 +602,7 @@ controls:
>   
>     - ColourTemperature:
>         type: int32_t
> -      direction: out
> +      direction: inout
>         description: |
>           ColourTemperature of the frame, in kelvin.
>
David Plowman Nov. 12, 2026, 10:39 a.m. UTC | #2
Hi Naush

Thanks for the patch.

On Thu, 12 Nov 2026 at 10:38, Barnabás Pőcze
<barnabas.pocze@ideasonboard.com> wrote:
>
> 2026. 11. 12. 11:23 keltezéssel, Naushir Patuck írta:
> > This control is now writable, so fix the direction to inout.
> >
> > Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable")
> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> > ---
>
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

David

>
>
> >   src/libcamera/control_ids_core.yaml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> > index 73643e7e84ae..6504f983faa6 100644
> > --- a/src/libcamera/control_ids_core.yaml
> > +++ b/src/libcamera/control_ids_core.yaml
> > @@ -602,7 +602,7 @@ controls:
> >
> >     - ColourTemperature:
> >         type: int32_t
> > -      direction: out
> > +      direction: inout
> >         description: |
> >           ColourTemperature of the frame, in kelvin.
> >
>

Patch
diff mbox series

diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
index 73643e7e84ae..6504f983faa6 100644
--- a/src/libcamera/control_ids_core.yaml
+++ b/src/libcamera/control_ids_core.yaml
@@ -602,7 +602,7 @@  controls:
 
   - ColourTemperature:
       type: int32_t
-      direction: out
+      direction: inout
       description: |
         ColourTemperature of the frame, in kelvin.