| Message ID | 20200227030001.333291-3-helen.koike@collabora.com |
|---|---|
| State | Accepted |
| Commit | ad5d123578ca5b0cd8ed43a8d21a62cc55422870 |
| Headers | show |
| Series |
|
| Related | show |
Hi Helen, Thank you for the patch. On Thu, Feb 27, 2020 at 12:00:01AM -0300, Helen Koike wrote: > Link between resizer and capture is immutable and doesn't need to be > enabled. > > Signed-off-by: Helen Koike <helen.koike@collabora.com> Just with s/don't/Don't/ in the subject line, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 7f7e1ad..0589d38 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks() > if (ret < 0) > return ret; > > - link = media_->link("rkisp1_resizer_mainpath", 1, "rkisp1_mainpath", 0); > - if (!link) > - return -ENODEV; > - > - ret = link->setEnabled(true); > - if (ret < 0) > - return ret; > - > return 0; > } >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 7f7e1ad..0589d38 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks() if (ret < 0) return ret; - link = media_->link("rkisp1_resizer_mainpath", 1, "rkisp1_mainpath", 0); - if (!link) - return -ENODEV; - - ret = link->setEnabled(true); - if (ret < 0) - return ret; - return 0; }
Link between resizer and capture is immutable and doesn't need to be enabled. Signed-off-by: Helen Koike <helen.koike@collabora.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 -------- 1 file changed, 8 deletions(-)