[RFC,v1] ipa: rkisp1: imx219: Add `GammaOutCorrection`
diff mbox series

Message ID 20261106172057.1358566-1-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • [RFC,v1] ipa: rkisp1: imx219: Add `GammaOutCorrection`
Related show

Commit Message

Barnabás Pőcze Nov. 6, 2026, 5:20 p.m. UTC
This is a useful algorithm to have by default, so add it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/rkisp1/data/imx219.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham Nov. 6, 2026, 6:07 p.m. UTC | #1
Quoting Barnabás Pőcze (2026-11-06 17:20:57)
> This is a useful algorithm to have by default, so add it.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/ipa/rkisp1/data/imx219.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml
> index 0d99cb5293..71fe85ba46 100644
> --- a/src/ipa/rkisp1/data/imx219.yaml
> +++ b/src/ipa/rkisp1/data/imx219.yaml
> @@ -111,4 +111,5 @@ algorithms:
>                 1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,
>                 1326, 1334, 1334,
>               ]
> +  - GammaOutCorrection:

Does adding this need the AGC targets to be changed in the tuning file?
or is the tuning file using the built-in defaults already?

Are there any other files impacted ?

Otherwise:


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  ...
> -- 
> 2.56.0
>

Patch
diff mbox series

diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml
index 0d99cb5293..71fe85ba46 100644
--- a/src/ipa/rkisp1/data/imx219.yaml
+++ b/src/ipa/rkisp1/data/imx219.yaml
@@ -111,4 +111,5 @@  algorithms:
                1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,
                1326, 1334, 1334,
              ]
+  - GammaOutCorrection:
 ...