[v7,5/5] libcamera: software_isp: Add support for monochrome formats - SOFT
diff mbox series

Message ID 20261026082602.60417-6-alain.cousinie@laposte.net
State New
Headers show
Series
  • libcamera: software_isp: Add support for raw monochrome formats
Related show

Commit Message

Alain Cousinie Oct. 26, 2026, 8:26 a.m. UTC 
Signed-off-by: Alain Cousinié <alain.cousinie@laposte.net>
---
 src/libcamera/software_isp/software_isp.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

--
2.55.0

Comments

Milan Zamazal Oct. 26, 2026, 5:58 p.m. UTC | #1 
alain.cousinie@laposte.net writes:

> Signed-off-by: Alain Cousinié <alain.cousinie@laposte.net>

This patch definitely needs explanation in the commit message.

> ---
>  src/libcamera/software_isp/software_isp.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index 627625b4f..4784804ee 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -294,6 +294,17 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,
>  	if (ret < 0)
>  		return ret;
>
> +	BayerFormat bayerFormat = BayerFormat::fromPixelFormat(inputCfg.pixelFormat);
> +	if (bayerFormat.order == BayerFormat::Order::MONO) {
> +		/* \todo Move to IPA uncalibrated-mono.yaml when lifecycle allows */

What's the idea exactly?

> +		ccmEnabled_ = false;
> +		lscEnabled_ = false;

Why to disable LSC with mono?

> +	} else {
> +		/* \todo Move to IPA uncalibrated.yaml when lifecycle allows */
> +		ccmEnabled_ = true;
> +		lscEnabled_ = true;

Why to set these two to true unconditionally?  Both could be true or
false before introducing mono formats.

> +	}
> +
>  	ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_, lscEnabled_);
>  	if (ret < 0)
>  		return ret;
> --
> 2.55.0

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index 627625b4f..4784804ee 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -294,6 +294,17 @@  int SoftwareIsp::configure(const StreamConfiguration &inputCfg,
 	if (ret < 0)
 		return ret;

+	BayerFormat bayerFormat = BayerFormat::fromPixelFormat(inputCfg.pixelFormat);
+	if (bayerFormat.order == BayerFormat::Order::MONO) {
+		/* \todo Move to IPA uncalibrated-mono.yaml when lifecycle allows */
+		ccmEnabled_ = false;
+		lscEnabled_ = false;
+	} else {
+		/* \todo Move to IPA uncalibrated.yaml when lifecycle allows */
+		ccmEnabled_ = true;
+		lscEnabled_ = true;
+	}
+
 	ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_, lscEnabled_);
 	if (ret < 0)
 		return ret;