[v2] v4l2: v4l2_camera_proxy: Fix default frame interval
diff mbox series

Message ID 20261021090630.825260-1-ragaprasanth@gmail.com
State New
Headers show
Series
  • [v2] v4l2: v4l2_camera_proxy: Fix default frame interval
Related show

Commit Message

Prasanth Ramesh Oct. 21, 2026, 9:06 a.m. UTC
The frame interval is meant to default to 30fps,
but it is set to 333333/1000000 seconds, which is 3fps.
Use 33333 microseconds instead.

Signed-off-by: Prasanth R <ragaprasanth@gmail.com>
---
 src/v4l2/v4l2_camera_proxy.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Oct. 21, 2026, 10:31 a.m. UTC | #1
Quoting Prasanth R (2026-10-21 10:06:30)
> The frame interval is meant to default to 30fps,
> but it is set to 333333/1000000 seconds, which is 3fps.
> Use 33333 microseconds instead.
> 
> Signed-off-by: Prasanth R <ragaprasanth@gmail.com>

Carrying existing tags forward:

Fixes: 77438775b39b ("v4l2: v4l2_camera_proxy: Fix VIDIOC_[GS]_PARM support")
Acked-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index 554e81f8d..7f8522d5e 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)
>                 LOG(V4L2Compat, Warning)
>                         << "Camera does not support FrameDurationLimits";
>  
> -               v4l2TimePerFrame_.numerator = 333333;
> +               v4l2TimePerFrame_.numerator = 33333;
>                 v4l2TimePerFrame_.denominator = 1000000;
>         }
>  }
> -- 
> 2.34.1
>

Patch
diff mbox series

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index 554e81f8d..7f8522d5e 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -274,7 +274,7 @@  void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)
 		LOG(V4L2Compat, Warning)
 			<< "Camera does not support FrameDurationLimits";
 
-		v4l2TimePerFrame_.numerator = 333333;
+		v4l2TimePerFrame_.numerator = 33333;
 		v4l2TimePerFrame_.denominator = 1000000;
 	}
 }