| Message ID | 20261019184526.252977-4-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabas On Mon, Oct 19, 2026 at 08:45:10PM +0200, Barnabás Pőcze wrote: > These getters have not been used since their introduction, so remove > them for now. They can be easily restored if needed. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/libipa/exposure_mode_helper.cpp | 25 ------------------------- > src/ipa/libipa/exposure_mode_helper.h | 5 ----- > 2 files changed, 30 deletions(-) > > diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp > index ef14729471..380edee825 100644 > --- a/src/ipa/libipa/exposure_mode_helper.cpp > +++ b/src/ipa/libipa/exposure_mode_helper.cpp > @@ -294,31 +294,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const > exposure / (exposureTime * gain * quantGain) }; > } > > -/** > - * \fn ExposureModeHelper::minExposureTime() > - * \brief Retrieve the configured minimum exposure time limit set through > - * setLimits() > - * \return The minExposureTime_ value > - */ > - > -/** > - * \fn ExposureModeHelper::maxExposureTime() > - * \brief Retrieve the configured maximum exposure time set through setLimits() > - * \return The maxExposureTime_ value > - */ > - > -/** > - * \fn ExposureModeHelper::minGain() > - * \brief Retrieve the configured minimum gain set through setLimits() > - * \return The minGain_ value > - */ > - > -/** > - * \fn ExposureModeHelper::maxGain() > - * \brief Retrieve the configured maximum gain set through setLimits() > - * \return The maxGain_ value > - */ > - > } /* namespace ipa */ > > } /* namespace libcamera */ > diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h > index c474cc2c13..a9398d3b4c 100644 > --- a/src/ipa/libipa/exposure_mode_helper.h > +++ b/src/ipa/libipa/exposure_mode_helper.h > @@ -40,11 +40,6 @@ public: > > [[nodiscard]] Result splitExposure(utils::Duration exposure) const; > > - utils::Duration minExposureTime() const { return minExposureTime_; } > - utils::Duration maxExposureTime() const { return maxExposureTime_; } > - double minGain() const { return minGain_; } > - double maxGain() const { return maxGain_; } > - > private: > utils::Duration clampExposureTime(utils::Duration exposureTime, > double *quantizationGain = nullptr) const; > -- > 2.56.0 >
diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp index ef14729471..380edee825 100644 --- a/src/ipa/libipa/exposure_mode_helper.cpp +++ b/src/ipa/libipa/exposure_mode_helper.cpp @@ -294,31 +294,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const exposure / (exposureTime * gain * quantGain) }; } -/** - * \fn ExposureModeHelper::minExposureTime() - * \brief Retrieve the configured minimum exposure time limit set through - * setLimits() - * \return The minExposureTime_ value - */ - -/** - * \fn ExposureModeHelper::maxExposureTime() - * \brief Retrieve the configured maximum exposure time set through setLimits() - * \return The maxExposureTime_ value - */ - -/** - * \fn ExposureModeHelper::minGain() - * \brief Retrieve the configured minimum gain set through setLimits() - * \return The minGain_ value - */ - -/** - * \fn ExposureModeHelper::maxGain() - * \brief Retrieve the configured maximum gain set through setLimits() - * \return The maxGain_ value - */ - } /* namespace ipa */ } /* namespace libcamera */ diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h index c474cc2c13..a9398d3b4c 100644 --- a/src/ipa/libipa/exposure_mode_helper.h +++ b/src/ipa/libipa/exposure_mode_helper.h @@ -40,11 +40,6 @@ public: [[nodiscard]] Result splitExposure(utils::Duration exposure) const; - utils::Duration minExposureTime() const { return minExposureTime_; } - utils::Duration maxExposureTime() const { return maxExposureTime_; } - double minGain() const { return minGain_; } - double maxGain() const { return maxGain_; } - private: utils::Duration clampExposureTime(utils::Duration exposureTime, double *quantizationGain = nullptr) const;
These getters have not been used since their introduction, so remove them for now. They can be easily restored if needed. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/libipa/exposure_mode_helper.cpp | 25 ------------------------- src/ipa/libipa/exposure_mode_helper.h | 5 ----- 2 files changed, 30 deletions(-)