| Message ID | 20261006-gc2145-support-v1-2-7482dfcde96f@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Alen Karnil (2026-10-06 09:23:32) > Provide libipa sensor helper for the GalaxyCore gc2145 sensor. > > The driver does not currently support gain control, so the helper's gain > has been a dummy/placeholder value. > > Signed-off-by: Alen Karnil <alen.karnil@ideasonboard.com> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index c00b997e..9cf7071d 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -520,6 +520,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("gc08a3", CameraSensorHelperGc08a3) > > +class CameraSensorHelperGc2145 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperGc2145() > + { > + /* gain is not exposed by the driver, this is just a place holder. */ > + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; Given we have both this and the Mira where we /don't/ want to set a gain model, maybe we should have something like gain_ = IdentityGainModel; /* Output code = int(gain) */ or gain_ = UnityGainModel; /* Always returns '1' or '1.0' */ And maybe one of those might be the default if gain_ isn't set ? -- Kieran > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("gc2145", CameraSensorHelperGc2145) > + > class CameraSensorHelperHm1246 : public CameraSensorHelper > { > public: > > -- > 2.53.0 >
Hi 2026. 10. 06. 10:23 keltezéssel, Alen Karnil írta: > Provide libipa sensor helper for the GalaxyCore gc2145 sensor. > > The driver does not currently support gain control, so the helper's gain > has been a dummy/placeholder value. > > Signed-off-by: Alen Karnil <alen.karnil@ideasonboard.com> > --- My slight worry about this is that this will potentially be used on devices running https://codeberg.org/megi/linux/src/branch/orange-pi-7.2/drivers/media/i2c/gc2145.c, which does implement V4L2_CID_ANALOGUE_GAIN, so it will be off in those cases. > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index c00b997e..9cf7071d 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -520,6 +520,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("gc08a3", CameraSensorHelperGc08a3) > > +class CameraSensorHelperGc2145 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperGc2145() > + { > + /* gain is not exposed by the driver, this is just a place holder. */ > + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("gc2145", CameraSensorHelperGc2145) > + > class CameraSensorHelperHm1246 : public CameraSensorHelper > { > public: >
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index c00b997e..9cf7071d 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -520,6 +520,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("gc08a3", CameraSensorHelperGc08a3) +class CameraSensorHelperGc2145 : public CameraSensorHelper +{ +public: + CameraSensorHelperGc2145() + { + /* gain is not exposed by the driver, this is just a place holder. */ + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("gc2145", CameraSensorHelperGc2145) + class CameraSensorHelperHm1246 : public CameraSensorHelper { public:
Provide libipa sensor helper for the GalaxyCore gc2145 sensor. The driver does not currently support gain control, so the helper's gain has been a dummy/placeholder value. Signed-off-by: Alen Karnil <alen.karnil@ideasonboard.com> --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+)