| Message ID | 20261005152231.2024537-1-dmanresa@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 82bf255..3589b06 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -802,6 +802,8 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper public: CameraSensorHelperOv5670() { + /* From the OEM black level characterisation: 64 at 10bits. */ + blackLevel_ = 4096; gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; } };
The OV5670 outputs a data pedestal of 64 at 10 bits. The black level characterisation in the OEM tuning data for a Dell Latitude 7275 camera module measures 64.1 to 64.4 at unity gain over six exposure times, and stays within 62.0 to 64.5 up to a gain of 15.9. Provide it in the camera sensor helper so that IPAs can use it instead of hard-coded or tuning-file values. Signed-off-by: D. Manresa <dmanresa@gmail.com> --- Written with the assistance of an AI tool (Claude). libcamera has no trailer for this and checkstyle.py rejects unknown trailer keys, so it is noted here rather than in the commit message. v5: move the camera_sensor_helper comment to 1/2, per Barnabás Pőcze's review of v4 2/2. This patch now introduces the comment already in its final wording. No functional change. src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+)