[libcamera-devel,PATCH/RFC,11/11] licenses: Add SPDX headers to Gentoo ebuild

Message ID 20200213153635.27953-12-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Improve license information
Related show

Commit Message

Laurent Pinchart Feb. 13, 2020, 3:36 p.m. UTC
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Feb. 13, 2020, 4:04 p.m. UTC | #1
Hi Laurent,

On 13/02/2020 15:36, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> index fc241b1f5584..b336932ef321 100644
> --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> @@ -1,5 +1,5 @@
> +# SPDX-License-Identifier: GPL-2.0-only
>  # Copyright 2019 Google Inc.
> -# Distributed under the terms of the GNU General Public License v2

As this is a build component, shouldn't it have been LGPL?

As long as it's correct (this change only converts to an SPDX anyway..)

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


>  
>  EAPI=6
>  PYTHON_COMPAT=( python3_{5,6,7} )
>
Laurent Pinchart Feb. 13, 2020, 4:28 p.m. UTC | #2
Hi Kieran,

On Thu, Feb 13, 2020 at 04:04:04PM +0000, Kieran Bingham wrote:
> On 13/02/2020 15:36, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > index fc241b1f5584..b336932ef321 100644
> > --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > @@ -1,5 +1,5 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> >  # Copyright 2019 Google Inc.
> > -# Distributed under the terms of the GNU General Public License v2
> 
> As this is a build component, shouldn't it have been LGPL?

It's a good question, which I've raised in the cover letter : what
should the build system files be licensed under ?

> As long as it's correct (this change only converts to an SPDX anyway..)
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> >  EAPI=6
> >  PYTHON_COMPAT=( python3_{5,6,7} )

Patch

diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
index fc241b1f5584..b336932ef321 100644
--- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
+++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
@@ -1,5 +1,5 @@ 
+# SPDX-License-Identifier: GPL-2.0-only
 # Copyright 2019 Google Inc.
-# Distributed under the terms of the GNU General Public License v2
 
 EAPI=6
 PYTHON_COMPAT=( python3_{5,6,7} )